Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vtxo.CreatedAt #295

Open
altafan opened this issue Sep 5, 2024 · 3 comments
Open

Add vtxo.CreatedAt #295

altafan opened this issue Sep 5, 2024 · 3 comments

Comments

@altafan
Copy link
Collaborator

altafan commented Sep 5, 2024

The vtxo contains info about when it expires but not about when it was created.

ATM can determine the creation timestamp for a vtxo with vtxo.ExpiresAt - asp.RoundLifetime but with the assumption that the ASP never changes the round lifetime. Impossible to calculate the timestamp for a pending vtxo instead.

@tiero
Copy link
Member

tiero commented Sep 5, 2024

I would concur that also having a way to carry the data related to the shared output could be useful. You could infer the "genesis" from the block time, but having both is useful

@altafan
Copy link
Collaborator Author

altafan commented Sep 5, 2024

atm the vtxo struct includes a field for the round txid. Don't you think this is enough? storing the same data for many vtxos doesn't seem to me a good idea

@tiero
Copy link
Member

tiero commented Sep 5, 2024

Yea not talking about storage, not on the interface would be handy to join together all info that are helpful. Txid is perfect indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants