Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add tweak name as prefix for exported settings #727

Open
1 task done
yodaluca23 opened this issue Jun 16, 2024 · 2 comments
Open
1 task done

[Request] Add tweak name as prefix for exported settings #727

yodaluca23 opened this issue Jun 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@yodaluca23
Copy link

yodaluca23 commented Jun 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Do you use YouTube Premium?

❌ No, I don't use YouTube Premium

My feature request

It would be easier to read/manually modify, the settings export, if it had prefixes based on what tweak the setting is from.
Example, uYouEnhanced settings could be prefixed "Enhanced.setting" for example "Enhanced.hideThanksButton_enabled: 1" uYou settings could be prefixed "uYou.setting" for example "uYou.removeYouTubeAds: 0" YouPiP could be prefixed "YouPiP.setting" (backup settings does not support YouPiP at least not on the version I'm on, so the setting key is theoretical) for example "YouPiP.legacyPiP_enabled: 0"

Additional context

This would also allow it to work if two tweaks have the same key names.

@yodaluca23 yodaluca23 added the enhancement New feature or request label Jun 16, 2024
@arichornlover
Copy link
Owner

arichornlover commented Jun 16, 2024

It would be easier to read/manually modify, the settings export, if it had prefixes based on what tweak the setting is from.
Example, uYouEnhanced settings could be prefixed "Enhanced.setting" for example "Enhanced.hideThanksButton_enabled: 1" uYou settings could be prefixed "uYou.setting" for example "uYou.removeYouTubeAds: 0" YouPiP could be prefixed "YouPiP.setting"

Of course I could add that.

(backup settings does not support YouPiP at least not on the version I'm on, so the setting key is theoretical) for example "YouPiP.legacyPiP_enabled: 0"

the reason why YouPiP doesn’t support backup settings is because I had to manually add the keys in an NSArray. I could expand it and support more options if I could find the correct keys when backing up settings.

@yodaluca23
Copy link
Author

the reason why YouPiP doesn’t support backup settings is because I had to manually add the keys in an NSArray. I could expand it and support more options if I could find the correct keys when backing up settings.

I know, I know, I was just saying that I didn't know what the actual setting would be called, I was just making something up to show what it could look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants