Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #449

Open
rzinke opened this issue Oct 21, 2024 · 1 comment
Open

[BUG] #449

rzinke opened this issue Oct 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rzinke
Copy link
Collaborator

rzinke commented Oct 21, 2024

Describe the bug
ariaTSsetup.py errors out when the 'all' argument is passed to layers. This is caused by ariaTSsetup.py attempting to extract the 'lookAngle' and 'bPerpendicluar' layers, which are not part of the ARIA_STACK_OUTFILES, causing an Exception to be raised.

Instead of erroring out, ariaTSsetup.py should raise a warning and continue processing the other "stack" products.

To Reproduce
Steps to reproduce the behavior:

  1. Download
ariaDownload.py -t 71 -b '37.5 39.5 -118.5 -114.5' -s 20200515 -e 20200601 --version 3 -o download
  1. Command used
ariaTSsetup.py -f "products/*.nc" -d download -l all
  1. Error Output
2024-10-21 13:36:56,635 - ariaTSsetup.py - INFO - setStack stack generated
Traceback (most recent call last):
  File "/opt/miniconda3/envs/insarXX/bin/ariaTSsetup.py", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/Users/rzinke/Tools/ARIA-tools/tools/bin/ariaTSsetup.py", line 671, in <module>
    main()
  File "/Users/rzinke/Tools/ARIA-tools/tools/bin/ariaTSsetup.py", line 665, in main
    raise Exception(f'Selected {layer} not supported in tsSetup' + msg)
Exception: Selected lookAngle not supported in tsSetupAvailable layers are: dict_keys(['unwrappedPhase', 'gacos_corrections', 'coherence', 'connectedComponents', 'bParallel', 'amplitude', 'troposphereHydrostatic', 'troposphereWet', 'troposphereTotal', 'ionosphere', 'solidEarthTide', 'ERA5', 'GMAO', 'HRES', 'HRRR', 'GACOS'])

Expected behavior
Skip the non-stack product and process the rest.
Prefer to raise LOGGER.warning and continue.

@rzinke rzinke added the bug Something isn't working label Oct 21, 2024
@rzinke
Copy link
Collaborator Author

rzinke commented Oct 21, 2024

Suggested fix in PR #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants