build(docs): set site_url
from ReadTheDocs env var
#13685
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
site_url
is required for canonicalization, which is a prereq for proper styling on 404s and creating asitemap.xml
Also for certain features like:
Modifications
site_url
config tomkdocs.yml
Verification
mkdocs serve
http://127.0.0.1:8000/en/latest/
now -- workshttp://127.0.0.1:8000/en/latest/sitemap.xml
-- actually has content nowhttp://127.0.0.1:8000/en/latest/wrong
-- has a properly styled 404 page.Screenshot: