-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go mod should not require k8s.io/kubernetes #473
Comments
In order to remove our dependency on k/k, we need to find replacements for the following:
I think that's all the function calls from the k/k library. I think some of these function calls will be easy to duplicate or find in a different library, but I'm concerned others will be less flexible. |
Other argo projects are dealing with this too. |
The issue appears for the latest release (v1.1.1) as well (Checkout code step in https://argoproj.github.io/argo-rollouts/CONTRIBUTING/#pre-requisites). Should simply use git clone/checkout?
|
This issue is stale because it has been open 60 days with no activity. |
Hi folks. Do you happen to have any updates on this issue? |
The latest argo-rollouts v0.8.0 go.mod should not require k8s.io/kubernetes. When I upgraded from "github.com/argoproj/argo-rollouts v0.7.2" to "github.com/argoproj/argo-rollouts v0.8.0" "go mod tidy" reports the following errors:
For example:
do this: import "k8s.io/api"
not this: import "k8s.io/kubernetes/pkg/api"
do this: import "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
not this: import "k8s.io/kubernetes/pkg/controller"
See: kubernetes/kubernetes#81878
The text was updated successfully, but these errors were encountered: