Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovery.k8s.io/EndpointSlice to ignoredRefreshResources to skip app requeueing #18857

Open
andrii-korotkov-verkada opened this issue Jun 30, 2024 · 2 comments
Labels
bug/enhancement component:core Syncing, diffing, cluster state cache enhancement New feature or request type:enhancement

Comments

@andrii-korotkov-verkada
Copy link
Contributor

Summary

Currently /Endpoints are skipped when trying to trigger a reconciliation (link). I think discovery.k8s.io/EndpointSlice should be added to the list as well for the same reasons. Also, skipResourceUpdate should be done after skipAppRequeuing check for optimization.

Motivation

Do an additional optimization to reduce reconciliations. Other resources like pods would already trigger reconciliations when there are relevant updates.

Proposal

Just update the dictionary of ignoredRefreshResources mentioned above to include the entry for discovery.k8s.io/EndpointSlice

@andrii-korotkov-verkada andrii-korotkov-verkada added the enhancement New feature or request label Jun 30, 2024
@AnkurManna
Copy link

If approved, I'm willing to provide the PR.

@AnkurManna
Copy link

Please review argoproj/gitops-engine#596, as only after merging this i will be able to use these changes in argo-cd repo like https://argo-cd.readthedocs.io/en/stable/developer-guide/dependencies/ for the final pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/enhancement component:core Syncing, diffing, cluster state cache enhancement New feature or request type:enhancement
Projects
None yet
Development

No branches or pull requests

3 participants