Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final draft review (Prof Huff & Prof Munk) #8

Closed
smpark7 opened this issue Jan 7, 2025 · 2 comments
Closed

Final draft review (Prof Huff & Prof Munk) #8

smpark7 opened this issue Jan 7, 2025 · 2 comments
Assignees
Labels
Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:3-Selected The assignee has chosen to work on this item next (after their current, in progress, issue) Type:Docs Is related to API documentation, website content, etc.

Comments

@smpark7
Copy link
Collaborator

smpark7 commented Jan 7, 2025

This issue can be closed when Prof Huff and Prof Munk review and approve the final draft for this conference submission. The submission deadline is Jan 10 11.59pm CST.

I addressed the M&C reviewer comments listed in #6 and made several other changes to improve the flow.

The final draft is here: main.pdf

The latexdiff of the previous and current draft is here: diff.pdf

Summary of changes:

  • Provided definitions of several key mathematical variables such as neutron flux
  • Rearranged the model setup section to improve flow
  • Clarified that the main goal of this work is to provide baseline neutronics verification, and that simulations with precursor movement will come in a later publication
  • Bolded math/equations in table/figure headings
  • Removed unnecessary or repeated URLs in the bibliography to cut paper length
@smpark7 smpark7 added Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:3-Selected The assignee has chosen to work on this item next (after their current, in progress, issue) Type:Docs Is related to API documentation, website content, etc. labels Jan 7, 2025
@katyhuff
Copy link
Member

katyhuff commented Jan 7, 2025

Because figure 2 is no longer alongside many other figures explaining the meaning of the blue dots, I recommend including the blue dot in the legend or explaining in the caption that the dots are your simulation results.

Otherwise, looks great to me.

@munkm
Copy link
Member

munkm commented Jan 10, 2025

Thank you for including the diff in this issue. I think your overall improvements are good, and the sentence you added about this work being a baseline study without DNP movement was a good addition for the reviewer comments. I agree with Prof. Huff's comment on adding to the legend of Figure 2.

Great job!

@smpark7 smpark7 closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:3-Selected The assignee has chosen to work on this item next (after their current, in progress, issue) Type:Docs Is related to API documentation, website content, etc.
Projects
None yet
Development

No branches or pull requests

3 participants