Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twill 3: Handle Permissions should avoid trying to display deleted content. #2319

Closed
sauron opened this issue Aug 9, 2023 · 1 comment
Closed

Twill 3: Handle Permissions should avoid trying to display deleted content. #2319

sauron opened this issue Aug 9, 2023 · 1 comment
Assignees
@ifox
Labels
type: bug Something isn't working

Comments

@sauron
Copy link
Contributor

sauron commented Aug 9, 2023

I was able to replicate a bug that when a permissionable is deleted the getFormFieldsHandleUserPermissions raises an error for $model->id (link)

While this can be fixed by adding a defensive or failsafe check, It worth to verify if we should cascade delete or if we should display the "deleted" permissionable model despite the fact that is not visible.

@ifox Assigning to you for discussion.
@sauron sauron added type: bug Something isn't working type: question labels Aug 9, 2023
@ifox
Copy link
Member

ifox commented Feb 6, 2024 •
edited
Loading

Fixed in #2372

@ifox ifox closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifox ifox

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sauron @ifox