Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gRPC] Expose the timestamp flag when starting a Monitor #2337

Open
3 tasks done
kittaakos opened this issue Sep 25, 2023 · 0 comments
Open
3 tasks done

[gRPC] Expose the timestamp flag when starting a Monitor #2337

kittaakos opened this issue Sep 25, 2023 · 0 comments
Assignees
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Sep 25, 2023

Describe the request

As part of #2336, one can get the timestamp from the CLI. This is great, and IDE2 wants to use it.

Please add the timestamp property to the MonitorRequest. (Here is a PR that will change the same API: #2276).

As a pipedream, it would be great if the timestamp type could be boolean | string. When it's a string, it must be a valid date format string so that clients can change the output.

Describe the current behavior

There is no gRPC equivalent of monitor --timestamp

Arduino CLI version

5a4f48b

Operating system

macOS

Operating system version

13.5.2

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the nightly build
  • My request contains all necessary details
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants