Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global basedirs flag uses wrong default value #77

Closed
arcticicestudio opened this issue Jul 15, 2019 · 1 comment
Closed

Global basedirs flag uses wrong default value #77

arcticicestudio opened this issue Jul 15, 2019 · 1 comment
Labels
context-config context-pkg context-ui type-bug
Milestone
0.4.0

Comments

@arcticicestudio
Copy link
Owner

Epic: #33

The default value of the global basedirs flag is currently implemented to use the config.AppConfig.Snowblocks.Paths array instead of config.AppConfig.Snowblocks.BaseDirs resulting in invalid paths being processed by task runners and the configuration validators.
@arcticicestudio arcticicestudio added this to the 0.4.0 milestone Jul 15, 2019
@arcticicestudio arcticicestudio self-assigned this Jul 15, 2019
arcticicestudio added a commit that referenced this issue Jul 15, 2019
@arcticicestudio
Global basedirs flag uses wrong default value
ed6226d 
The default value of the global `basedirs` flag (1) used the
`config.AppConfig.Snowblocks.Paths` array instead of
`config.AppConfig.Snowblocks.BaseDirs` that resulted in invalid paths
being processed by task runners and the configuration validators.

References:
  (1) https://github.com/arcticicestudio/snowsaw/blob/145a4c36caf960fc9a43b16c105df997e819a04d/cmd/snowsaw/snowsaw.go#L74

Epic: GH-33
Fixes GH-77
@arcticicestudio
Copy link
Owner Author

Fixed in ed6226d

@arcticicestudio arcticicestudio removed their assignment Jul 15, 2019
@arcticicestudio arcticicestudio mentioned this issue Jul 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-config context-pkg context-ui type-bug
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@arcticicestudio