do not set empty mirror architectures for flat mirrors #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
- Coverage 74.83% 74.82% -0.01%
==========================================
Files 157 157
Lines 18094 18100 +6
==========================================
+ Hits 13540 13543 +3
- Misses 3456 3458 +2
- Partials 1098 1099 +1 ☔ View full report in Codecov by Sentry. |
neolynx
force-pushed
the
fix/flat-mirror-filtering
branch
4 times, most recently
from
f696399 to
23a4d6e
Compare
note: 'Architecture' is not official, but used by nvidia mirrors for no debian arch 'x86_64'. shold this be supported ?
neolynx
force-pushed
the
fix/flat-mirror-filtering
branch
4 times, most recently
from
fc7e083 to
aad12f8
Compare
neolynx
added
needs review
neolynx
force-pushed
the
fix/flat-mirror-filtering
branch
from
aad12f8 to
8fb7f21
Compare
neolynx
force-pushed
the
fix/flat-mirror-filtering
branch
from
8fb7f21 to
c86b888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1385
Description of the Change
when creating a mirror of a flat repository, aptly sets the architectures to nil. This prevents filtering with dependencies, because this is done by looping through the architectures.
This change fixes this by forcing all mirrors to have an architecture (and those which don't require the architectures specified when creating the mirror). If available, the architectures will be set from the Release file.
Checklist