Fix/add provided package #1386
Merged
Fix/add provided package #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolynx
force-pushed
the
fix/add-provided-package
branch
from
d382088 to
d6862e4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1386 +/- ##
=======================================
Coverage 74.86% 74.86%
=======================================
Files 157 157
Lines 18088 18090 +2
=======================================
+ Hits 13541 13543 +2
Misses 3450 3450
Partials 1097 1097 ☔ View full report in Codecov by Sentry. |
6 tasks
neolynx
force-pushed
the
fix/add-provided-package
branch
from
d6862e4 to
c028d5e
Compare
iofq
approved these changes
Nov 8, 2024
neolynx
force-pushed
the
fix/add-provided-package
branch
6 times, most recently
from
899e013 to
afafbfe
Compare
neolynx
force-pushed
the
fix/add-provided-package
branch
from
afafbfe to
9d05949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1378
Description of the Change
Since ab18d48 list.Search() is also returning provided packages. This is not wanted in all scenarios, for example then adding packages to a repository or in a snapshot pull.
Checklist