Make HTTP server wait for tasks before shutdown #1390
Conversation
|
excellent work ! thanks a lot :) I ran a coverage build: #1391 - 60.00% of diff hit (target 74.86%), which is good enough, but I was wondering if we can somehow test the Ctrl-C automatically. There is already a test for parallel operation with threads... do you think it would make sense to try to test this ? |
I added a unit test to cover the added lines. As far as a system test, I messed a bit but could not figure out how to cleanly shut down and re-init the test harness mid-test easily |
Fixes #1335
Description of the Change
This code change prevents SIGINT/SIGTERM signals from stopping the Aptly API server before it has cleaned up any resource locks in the database. Normally for CLI aptly commands, it would clear these locks if it detects the PID that had the previous lock is no longer running. However, if Aptly is running as an API server in a container, it always runs as PID 1, which means the PID no longer works as a unique identifier to detect what is running at any given time, leaving these locks indefinitely.
Even with this MR, this issue can still present itself if an Aptly container is SIGKILLed (docker rm -f), however that is a more difficult problem to solve that would likely take some significant rearchitecting (since the API was tacked on to aptly after the fact).
Checklist