Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid nil panic when downloadSpeedLimit is set in api mode #1330

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Avoid nil panic when downloadSpeedLimit is set in api mode #1330

merged 1 commit into from
Aug 16, 2024

Conversation

iofq
Copy link
Contributor

@iofq iofq commented Aug 15, 2024

Fixes #1329

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx self-assigned this Aug 16, 2024
@neolynx neolynx self-requested a review August 16, 2024 08:04
neolynx
neolynx approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@neolynx neolynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks !

@neolynx neolynx merged commit 372ce3c into aptly-dev:master Aug 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolynx neolynx neolynx approved these changes

Assignees

@neolynx neolynx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nil panic during api mirror create
2 participants
@iofq @neolynx