Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: our licenses.html file is not deterministically generated #1523

Open
abernix opened this issue Aug 17, 2022 · 3 comments
Open

infra: our licenses.html file is not deterministically generated #1523

abernix opened this issue Aug 17, 2022 · 3 comments
Labels
component/infra Related to internal infrastructure (e.g., tests, CI, tooling)

Comments

@abernix
Copy link
Member

abernix commented Aug 17, 2022

It would seem that the cargo about generate --workspace -o licenses.html about.hbs file generates different results (potentially based on different operating systems? glibc versions? Something else? Not sure.)

This results in our CI job which enforces compliance failing sporadically and succeeding on a "Re-run from Failed" invocation.

This will likely need to be fixed upstream, and @o0Ignition0o has opened EmbarkStudios/cargo-about#202 as a basis for collaboration, but this tracks that on our own repository as an infra chore.

@abernix abernix added the component/infra Related to internal infrastructure (e.g., tests, CI, tooling) label Aug 17, 2022
@o0Ignition0o
Copy link
Contributor

I believe a good first step would be to display the diff when the CI run fails.

@o0Ignition0o
Copy link
Contributor

#1524 adresses my comment above.

@o0Ignition0o
Copy link
Contributor

https://app.circleci.com/pipelines/github/apollographql/router/5656/workflows/2b807f0c-5ebd-4c99-aa09-e39d86742b8a/jobs/43516/parallel-runs/0/steps/0-116 is a CI fail example, I think things got moved around, also i cant quite figure out what the diff in some of the parts is:

index 74a2bb11..08dbf9cb 100644
--- a/licenses.html
+++ b/licenses.html
@@ -45,7 +45,7 @@
         <h2>Overview of licenses:</h2>
         <ul class="licenses-overview">
             <li><a href="#MIT">MIT License</a> (82)</li>
-            <li><a href="#Apache-2.0">Apache License 2.0</a> (56)</li>
+            <li><a href="#Apache-2.0">Apache License 2.0</a> (55)</li>
             <li><a href="#BSD-3-Clause">BSD 3-Clause &quot;New&quot; or &quot;Revised&quot; License</a> (8)</li>
             <li><a href="#ISC">ISC License</a> (8)</li>
             <li><a href="#BSD-2-Clause">BSD 2-Clause &quot;Simplified&quot; License</a> (2)</li>
@@ -10284,6 +10284,8 @@ limitations under the License.
                 <h3 id="Apache-2.0">Apache License 2.0</h3>
                 <h4>Used by:</h4>
                 <ul class="license-used-by">
+                    <li><a href=" https://github.com/BrynCooke/buildstructor ">buildstructor</a></li>
+                    <li><a href=" https://github.com/BrynCooke/buildstructor ">buildstructor</a></li>
                     <li><a href=" https://github.com/bikeshedder/deadpool ">deadpool-runtime</a></li>
                     <li><a href=" https://github.com/RustCrypto/signatures/tree/master/ecdsa ">ecdsa</a></li>
                     <li><a href=" https://github.com/graphql-rust/graphql-client ">graphql-introspection-query</a></li>
@@ -10668,28 +10670,6 @@ You may obtain a copy of the License at
 
     http://www.apache.org/licenses/LICENSE-2.0
 
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an &quot;AS IS&quot; BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-</pre>
-            </li>
-            <li class="license">
-                <h3 id="Apache-2.0">Apache License 2.0</h3>
-                <h4>Used by:</h4>
-                <ul class="license-used-by">
-                    <li><a href=" https://github.com/BrynCooke/buildstructor ">buildstructor</a></li>
-                    <li><a href=" https://github.com/BrynCooke/buildstructor ">buildstructor</a></li>
-                </ul>
-                <pre class="license-text">Copyright [2022] [Bryn Cooke]
-
-Licensed under the Apache License, Version 2.0 (the &quot;License&quot;);
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an &quot;AS IS&quot; BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

@abernix abernix added this to the post-v1.x milestone Sep 2, 2022
@abernix abernix removed this from the v1.x.x milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/infra Related to internal infrastructure (e.g., tests, CI, tooling)
Projects
None yet
Development

No branches or pull requests

2 participants