Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi): create app (#32) #44

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

ThugJudy
Copy link

@ThugJudy ThugJudy commented Nov 2, 2023

  • feat(openapi): create app

  • feat(openapi): create app

  • fix: remove create app by env

  • feat: support init admins when create app

  • refactor: path "apps/create" -> "apps"

  • test: move to IntegrationTest

  • Update AppOpenApiServiceTest.java

  • refactor: use OpenCreateAppDTO instead of OpenAppDTO

  • test: testCreateAppThenCreateNamespaceThenRelease

  • Update CHANGES.md

  • add assignAppRoleToSelf to mark role permission

  • testCreateAppButHaveNoAppRole

  • refactor: use composite instead of extend OpenAppDTO

  • Update OpenCreateAppDTO.java

  • test: make test more complex. create the cluster too

What's the purpose of this PR

Fix the test case com.ctrip.framework.apollo.openapi.client.service.ItemOpenApiServiceTest.testFindItemsByNamespace

Which issue(s) this PR fixes:

Fixes #43

Brief changelog

I propose using a LinkedHashMap, so that the order in which the params are inserted is preserved and flakiness is resolved.
https://github.com/ThugJudy/apollo-java/blob/d8e4352ff8c9e9c6fc37961c49d4b7018b47fc14/apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java#L64

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

* feat(openapi): create app

* feat(openapi): create app

* fix: remove create app by env

* feat: support init admins when create app

* refactor: path "apps/create" -> "apps"

* test: move to IntegrationTest

* Update AppOpenApiServiceTest.java

* refactor: use OpenCreateAppDTO instead of OpenAppDTO

* test: testCreateAppThenCreateNamespaceThenRelease

* Update CHANGES.md

* add assignAppRoleToSelf to mark role permission

* testCreateAppButHaveNoAppRole

* refactor: use composite instead of extend OpenAppDTO

* Update OpenCreateAppDTO.java

* test: make test more complex. create the cluster too
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #44 (d8e4352) into main (5344bc4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #44   +/-   ##
=========================================
  Coverage     68.59%   68.59%           
  Complexity     1206     1206           
=========================================
  Files           171      171           
  Lines          5196     5196           
  Branches        561      561           
=========================================
  Hits           3564     3564           
  Misses         1371     1371           
  Partials        261      261           
Files Coverage Δ
.../apollo/openapi/client/url/OpenApiPathBuilder.java 96.49% <100.00%> (ø)

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 21259e5 into apolloconfig:main Nov 3, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test testFindItemsByNamespace
3 participants