You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have confirmed that this should be classified as an enhancement rather than a bug/feature.
Summary
The method checkConfig in DefaultMQPullConusmerImpl and DefaultMQPushConsumerImpl exists unused code about producer group.
Validators#checkGroup has checked the group not empty, so don't need to check in checkConfig.
publicclassDefaultMQPullConusmerImpl {
// ...privatevoidcheckConfig() throwsMQClientException {
// because this method has check group not emptyValidators.checkGroup(this.defaultMQPullConsumer.getConsumerGroup());
// this check should be unnecessaryif (null == this.defaultMQPullConsumer.getConsumerGroup()) {
thrownewMQClientException(
"consumerGroup is null"
+ FAQUrl.suggestTodo(FAQUrl.CLIENT_PARAMETER_CHECK_URL),
null);
}
// ...
}
// ...
}
publicclassValidators {
// ...publicstaticvoidcheckGroup(Stringgroup) throwsMQClientException {
// check group is not null or emptyif (UtilAll.isBlank(group)) {
thrownewMQClientException("the specified group is blank", null);
}
// ...
}
// ...
}
Motivation
producer group don't need repeat check.
Describe the Solution You'd Like
Delete unnecessary code.
Describe Alternatives You've Considered
No.
Additional Context
No response
The text was updated successfully, but these errors were encountered:
Before Creating the Enhancement Request
Summary
The method
checkConfig
inDefaultMQPullConusmerImpl
andDefaultMQPushConsumerImpl
exists unused code about producer group.Validators#checkGroup
has checked the group not empty, so don't need to check incheckConfig
.Motivation
producer group don't need repeat check.
Describe the Solution You'd Like
Delete unnecessary code.
Describe Alternatives You've Considered
No.
Additional Context
No response
The text was updated successfully, but these errors were encountered: