diff --git a/minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/configuration/ingestors/RestChangeIngestorCommonTest.java b/minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/configuration/ingestors/RestChangeIngestorCommonTest.java index e10226a877ff..e7d31e25e7d2 100644 --- a/minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/configuration/ingestors/RestChangeIngestorCommonTest.java +++ b/minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/configuration/ingestors/RestChangeIngestorCommonTest.java @@ -20,7 +20,6 @@ import java.io.IOException; import java.nio.ByteBuffer; import java.util.Collections; -import okhttp3.Headers; import okhttp3.MediaType; import okhttp3.OkHttpClient; import okhttp3.Request; @@ -68,11 +67,6 @@ public void testGet() throws Exception { throw new IOException("Unexpected code " + response); } - Headers responseHeaders = response.headers(); - for (int i = 0; i < responseHeaders.size(); i++) { - System.out.println(responseHeaders.name(i) + ": " + responseHeaders.value(i)); - } - assertEquals(RestChangeIngestor.GET_TEXT, response.body().string()); verify(testNotifier, Mockito.never()).notifyListeners(Mockito.any(ByteBuffer.class)); } @@ -93,11 +87,6 @@ public void testFileUploadNewConfig() throws Exception { throw new IOException("Unexpected code " + response); } - Headers responseHeaders = response.headers(); - for (int i = 0; i < responseHeaders.size(); i++) { - System.out.println(responseHeaders.name(i) + ": " + responseHeaders.value(i)); - } - assertEquals("The result of notifying listeners:\nMockChangeListener successfully handled the configuration change\n", response.body().string()); verify(testNotifier, Mockito.times(1)).notifyListeners(Mockito.eq(ByteBuffer.wrap(testString.getBytes()))); @@ -119,11 +108,6 @@ public void testFileUploadSameConfig() throws Exception { throw new IOException("Unexpected code " + response); } - Headers responseHeaders = response.headers(); - for (int i = 0; i < responseHeaders.size(); i++) { - System.out.println(responseHeaders.name(i) + ": " + responseHeaders.value(i)); - } - assertEquals("Request received but instance is already running this config.", response.body().string()); verify(testNotifier, Mockito.never()).notifyListeners(Mockito.any()); diff --git a/minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/util/OrderedPropertiesTest.java b/minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/util/OrderedPropertiesTest.java index 5ac02a2fc224..6ec0b1f20c88 100644 --- a/minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/util/OrderedPropertiesTest.java +++ b/minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/util/OrderedPropertiesTest.java @@ -50,8 +50,6 @@ public void testOrderedProperties() throws IOException { String actualLine = actualReader.readLine(); if (!"#Tue Feb 21 11:03:08 EST 2017".equals(expectedLine)) { assertEquals(expectedLine, actualLine); - } else { - System.out.println("Skipping timestamp comment line"); } } assertNull(actualReader.readLine()); diff --git a/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java b/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java index 39f6b65be0f3..3023bc515f5a 100644 --- a/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java +++ b/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java @@ -21,6 +21,8 @@ import org.apache.nifi.parameter.ParameterLookup; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.util.Collections; import java.util.HashMap; @@ -39,6 +41,8 @@ public class TestStandardPreparedQuery { + private static final Logger logger = LoggerFactory.getLogger(TestStandardPreparedQuery.class); + @Test public void testSimpleReference() { final Map attrs = new HashMap<>(); @@ -69,7 +73,7 @@ public void test10MIterations() { assertEquals("world", prepared.evaluateExpressions(new StandardEvaluationContext(attrs), null)); } final long nanos = System.nanoTime() - start; - System.out.println(TimeUnit.NANOSECONDS.toMillis(nanos)); + logger.info("{}", TimeUnit.NANOSECONDS.toMillis(nanos)); } @Test @@ -83,8 +87,7 @@ public void test10MIterationsWithQuery() { assertEquals("world", Query.evaluateExpressions("${xx}", attrs, ParameterLookup.EMPTY)); } final long nanos = System.nanoTime() - start; - System.out.println(TimeUnit.NANOSECONDS.toMillis(nanos)); - + logger.info("{}", TimeUnit.NANOSECONDS.toMillis(nanos)); } @Test diff --git a/nifi-commons/nifi-hl7-query-language/src/test/java/org/apache/nifi/hl7/query/TestHL7Query.java b/nifi-commons/nifi-hl7-query-language/src/test/java/org/apache/nifi/hl7/query/TestHL7Query.java index f74619c774a8..ce944e6b9f4a 100644 --- a/nifi-commons/nifi-hl7-query-language/src/test/java/org/apache/nifi/hl7/query/TestHL7Query.java +++ b/nifi-commons/nifi-hl7-query-language/src/test/java/org/apache/nifi/hl7/query/TestHL7Query.java @@ -89,10 +89,6 @@ public void testAssignAliases() { possibleValueMap.put("C", valuesC); possibleValueMap.put("D", valuesD); - for (int i = 0; i < valuesA.size() * valuesB.size() * valuesC.size() * valuesD.size(); i++) { - System.out.println(i + " : " + HL7Query.assignAliases(possibleValueMap, i)); - } - verifyAssignments(HL7Query.assignAliases(possibleValueMap, 0), "a", "d", "e", "g"); verifyAssignments(HL7Query.assignAliases(possibleValueMap, 1), "b", "d", "e", "g"); verifyAssignments(HL7Query.assignAliases(possibleValueMap, 2), "c", "d", "e", "g"); diff --git a/nifi-commons/nifi-security-kerberos/src/test/java/org/apache/nifi/security/krb/KerberosUserIT.java b/nifi-commons/nifi-security-kerberos/src/test/java/org/apache/nifi/security/krb/KerberosUserIT.java index 9dc96854212b..1c89ae4c0e82 100644 --- a/nifi-commons/nifi-security-kerberos/src/test/java/org/apache/nifi/security/krb/KerberosUserIT.java +++ b/nifi-commons/nifi-security-kerberos/src/test/java/org/apache/nifi/security/krb/KerberosUserIT.java @@ -21,6 +21,8 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.api.io.TempDir; import org.mockito.Mockito; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import javax.security.auth.Subject; import javax.security.auth.kerberos.KerberosPrincipal; @@ -42,6 +44,8 @@ import static org.junit.jupiter.api.Assertions.assertThrows; public class KerberosUserIT { + private static final Logger logger = LoggerFactory.getLogger(KerberosUserIT.class); + private static KDCServer kdc; private static KerberosPrincipal principal1; @@ -155,11 +159,11 @@ public void testCheckTGTAndRelogin() throws InterruptedException { boolean performedRelogin = false; for (int i = 0; i < 30; i++) { Thread.sleep(1000); - System.out.println("checkTGTAndRelogin #" + i); + logger.info("checkTGTAndRelogin #{}", i); performedRelogin = user1.checkTGTAndRelogin(); if (performedRelogin) { - System.out.println("Performed relogin!"); + logger.info("Performed relogin!"); break; } } @@ -179,7 +183,7 @@ public void testCheckTGTAndRelogin() throws InterruptedException { long currentTimeMillis = System.currentTimeMillis(); long startMilli = kerberosTicket.getStartTime().toInstant().toEpochMilli(); long endMilli = kerberosTicket.getEndTime().toInstant().toEpochMilli(); - System.out.println("New ticket is valid for " + TimeUnit.MILLISECONDS.toSeconds(endMilli - startMilli) + " seconds"); + logger.info("New ticket is valid for {}", TimeUnit.MILLISECONDS.toSeconds(endMilli - startMilli) + " seconds"); assertTrue(startMilli < currentTimeMillis); assertTrue(endMilli > currentTimeMillis); } diff --git a/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java b/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java index a945814ae4bc..fcf2f221acc6 100644 --- a/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java +++ b/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java @@ -19,6 +19,8 @@ import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Timeout; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; @@ -35,6 +37,8 @@ @Disabled("Tests are time-based") public class TestLeakyBucketThrottler { + private static final Logger logger = LoggerFactory.getLogger(TestLeakyBucketThrottler.class); + @Test @Timeout(value = 10000, unit = TimeUnit.MILLISECONDS) public void testOutputStreamInterface() throws IOException { @@ -144,7 +148,7 @@ public void run() { long millisElapsed = now - startMillis; bytesWritten += data.length; float bytesPerSec = (float) bytesWritten / (float) millisElapsed * 1000F; - System.out.println(idx + " : copied data at a rate of " + bytesPerSec + " bytes/sec"); + logger.info("{} : copied data at a rate of {} bytes/sec", idx, bytesPerSec); } } diff --git a/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/util/TestLineDemarcator.java b/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/util/TestLineDemarcator.java index f2ce73745890..a28d2b1e6d1f 100644 --- a/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/util/TestLineDemarcator.java +++ b/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/util/TestLineDemarcator.java @@ -19,6 +19,8 @@ import org.apache.nifi.stream.io.RepeatingInputStream; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.ByteArrayInputStream; import java.io.IOException; @@ -36,6 +38,8 @@ public class TestLineDemarcator { + private static final Logger logger = LoggerFactory.getLogger(TestLineDemarcator.class); + @Test public void testSingleCharacterLines() throws IOException { final String input = "A\nB\nC\rD\r\nE\r\nF\r\rG"; @@ -120,7 +124,7 @@ public void testPerformance() throws IOException { } final long millis = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - start); - System.out.println("Took " + millis + " millis to demarcate " + count + " lines"); + logger.info("Took {} millis to demarcate {} lines", millis, count); } } diff --git a/nifi-commons/nifi-write-ahead-log/src/test/java/org/apache/nifi/wali/TestSequentialAccessWriteAheadLog.java b/nifi-commons/nifi-write-ahead-log/src/test/java/org/apache/nifi/wali/TestSequentialAccessWriteAheadLog.java index 6eee5eedd189..84d42dd54604 100644 --- a/nifi-commons/nifi-write-ahead-log/src/test/java/org/apache/nifi/wali/TestSequentialAccessWriteAheadLog.java +++ b/nifi-commons/nifi-write-ahead-log/src/test/java/org/apache/nifi/wali/TestSequentialAccessWriteAheadLog.java @@ -20,6 +20,8 @@ import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.TestInfo; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.wali.DummyRecord; import org.wali.DummyRecordSerde; import org.wali.SerDeFactory; @@ -50,6 +52,9 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class TestSequentialAccessWriteAheadLog { + + private static final Logger logger = LoggerFactory.getLogger(TestSequentialAccessWriteAheadLog.class); + @Test public void testUpdateWithExternalFile(TestInfo testInfo) throws IOException { final DummyRecordSerde serde = new DummyRecordSerde(); @@ -369,11 +374,11 @@ public void run() { final String bps = NumberFormat.getInstance().format(bytesPerSecond); if (j == 0) { - System.out.println(millis + " ms to insert " + updateCountPerThread * numThreads + " updates using " + numThreads - + " threads, *as a warmup!* " + eps + " events per second, " + bps + " bytes per second"); + logger.info("{} ms to insert {} updates using {} threads, *as a warmup!* {} events per second, {} bytes per second", + millis, updateCountPerThread * numThreads, numThreads, eps, bps); } else { - System.out.println(millis + " ms to insert " + updateCountPerThread * numThreads + " updates using " + numThreads - + " threads, " + eps + " events per second, " + bps + " bytes per second"); + logger.info("{} ms to insert {} updates using {} threads, {} events per second, {} bytes per second", + millis, updateCountPerThread * numThreads, numThreads, eps, bps); } } } diff --git a/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/dynamodb/PutDynamoDBTest.java b/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/dynamodb/PutDynamoDBTest.java index db05919aec63..f7273f5f9926 100644 --- a/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/dynamodb/PutDynamoDBTest.java +++ b/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/dynamodb/PutDynamoDBTest.java @@ -169,7 +169,6 @@ public void testStringHashStringRangePutSuccessfulWithMock() throws Initializati final List flowFiles = putRunner.getFlowFilesForRelationship(AbstractDynamoDBProcessor.REL_SUCCESS); for (final MockFlowFile flowFile : flowFiles) { - System.out.println(flowFile.getAttributes()); assertEquals(document, new String(flowFile.toByteArray())); } } @@ -191,14 +190,12 @@ public void testStringHashStringRangePutOneSuccessfulOneSizeFailureWithMockBatch final List flowFilesFailed = putRunner.getFlowFilesForRelationship(AbstractDynamoDBProcessor.REL_FAILURE); for (final MockFlowFile flowFile : flowFilesFailed) { - System.out.println(flowFile.getAttributes()); flowFile.assertAttributeExists(PutDynamoDB.AWS_DYNAMO_DB_ITEM_SIZE_ERROR); assertEquals(item.length, flowFile.getSize()); } final List flowFilesSuccessful = putRunner.getFlowFilesForRelationship(AbstractDynamoDBProcessor.REL_SUCCESS); for (final MockFlowFile flowFile : flowFilesSuccessful) { - System.out.println(flowFile.getAttributes()); assertEquals(document, new String(flowFile.toByteArray())); } } @@ -221,14 +218,12 @@ public void testStringHashStringRangePutOneSuccessfulOneSizeFailureWithMockBatch final List flowFilesFailed = putRunner.getFlowFilesForRelationship(AbstractDynamoDBProcessor.REL_FAILURE); for (final MockFlowFile flowFile : flowFilesFailed) { - System.out.println(flowFile.getAttributes()); flowFile.assertAttributeExists(PutDynamoDB.AWS_DYNAMO_DB_ITEM_SIZE_ERROR); assertEquals(item.length, flowFile.getSize()); } final List flowFilesSuccessful = putRunner.getFlowFilesForRelationship(AbstractDynamoDBProcessor.REL_SUCCESS); for (final MockFlowFile flowFile : flowFilesSuccessful) { - System.out.println(flowFile.getAttributes()); assertEquals(document, new String(flowFile.toByteArray())); } } @@ -250,7 +245,6 @@ public void testStringHashStringRangePutFailedWithItemSizeGreaterThan400Kb() thr final List flowFiles = putRunner.getFlowFilesForRelationship(AbstractDynamoDBProcessor.REL_FAILURE); assertEquals(1, flowFiles.size()); for (final MockFlowFile flowFile : flowFiles) { - System.out.println(flowFile.getAttributes()); flowFile.assertAttributeExists(PutDynamoDB.AWS_DYNAMO_DB_ITEM_SIZE_ERROR); assertEquals(item.length, flowFile.getSize()); } diff --git a/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITFetchS3Object.java b/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITFetchS3Object.java index d3acad8c9b1f..30ec31ae9269 100644 --- a/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITFetchS3Object.java +++ b/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITFetchS3Object.java @@ -23,6 +23,8 @@ import org.apache.nifi.util.TestRunner; import org.apache.nifi.util.TestRunners; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.IOException; import java.nio.file.Files; @@ -35,6 +37,8 @@ * Provides integration level testing with actual AWS S3 resources for {@link FetchS3Object} and requires additional configuration and resources to work. */ public class ITFetchS3Object extends AbstractS3IT { + private static final Logger logger = LoggerFactory.getLogger(ITFetchS3Object.class); + @Test public void testSimpleGet() throws IOException { putTestFile("test-file", getFileFromResourceName(SAMPLE_FILE_RESOURCE_NAME)); @@ -125,7 +129,7 @@ public void testContentsOfFileRetrieved() throws IOException { out.assertContentEquals(new String(expectedBytes)); for (final Map.Entry entry : out.getAttributes().entrySet()) { - System.out.println(entry.getKey() + " : " + entry.getValue()); + logger.info("{}:{}", entry.getKey(), entry.getValue()); } } diff --git a/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java b/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java index c3dd35d39564..3f9f3514a0bc 100644 --- a/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java +++ b/nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java @@ -44,6 +44,8 @@ import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.FileInputStream; import java.io.FileOutputStream; @@ -81,7 +83,7 @@ public class ITPutS3Object extends AbstractS3IT { final static Pattern reS3ETag = Pattern.compile("[0-9a-fA-f]{32}(-[0-9]+)?"); - + private static final Logger logger = LoggerFactory.getLogger(ITPutS3Object.class); private static String kmsKeyId = ""; private static String randomKeyMaterial = ""; @@ -710,7 +712,7 @@ public void testMultipartSmallerThanMinimum() throws IOException { tempByteCount += megabyte.length; } tempOut.close(); - System.out.println("file size: " + tempByteCount); + logger.info("file size: {}", tempByteCount); assertTrue(tempByteCount < S3_MINIMUM_PART_SIZE); assertTrue(megabyte.length < S3_MINIMUM_PART_SIZE); @@ -754,7 +756,7 @@ public void testMultipartBetweenMinimumAndMaximum() throws IOException, Initiali tempByteCount += megabyte.length; } tempOut.close(); - System.out.println("file size: " + tempByteCount); + logger.info("file size: {}", tempByteCount); assertTrue(tempByteCount > S3_MINIMUM_PART_SIZE && tempByteCount < S3_MAXIMUM_OBJECT_SIZE); assertTrue(tempByteCount > TEST_PARTSIZE_LONG); @@ -806,7 +808,7 @@ public void testObjectTags() throws IOException { List objectTags = result.getTagSet(); for (Tag tag : objectTags) { - System.out.println("Tag Key : " + tag.getKey() + ", Tag Value : " + tag.getValue()); + logger.info("Tag Key : {}, Tag Value : {}", tag.getKey(), tag.getValue()); } assertEquals(1, objectTags.size()); diff --git a/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-reporting-task/src/test/java/org/apache/nifi/reporting/azure/loganalytics/TestMetricsFactory.java b/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-reporting-task/src/test/java/org/apache/nifi/reporting/azure/loganalytics/TestMetricsFactory.java index 0dcb13af9c66..b0957ebfb4db 100644 --- a/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-reporting-task/src/test/java/org/apache/nifi/reporting/azure/loganalytics/TestMetricsFactory.java +++ b/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-reporting-task/src/test/java/org/apache/nifi/reporting/azure/loganalytics/TestMetricsFactory.java @@ -64,8 +64,6 @@ public void testGetDataFlowMetrics() { public void testGetVirtualMachineMetrics() { JvmMetrics virtualMachineMetrics = JmxJvmMetrics.getInstance(); List metrics = AzureLogAnalyticsMetricsFactory.getJvmMetrics(virtualMachineMetrics, "testcase", "tests"); - String metricsInString = gson.toJson(metrics); - System.out.println(metricsInString); TestVerification.assertJVMMetrics(metrics); } diff --git a/nifi-extension-bundles/nifi-compress-bundle/nifi-compress-processors/src/test/java/org/apache/nifi/processors/compress/TestModifyCompression.java b/nifi-extension-bundles/nifi-compress-bundle/nifi-compress-processors/src/test/java/org/apache/nifi/processors/compress/TestModifyCompression.java index e98f38192409..03c69a632e4b 100644 --- a/nifi-extension-bundles/nifi-compress-bundle/nifi-compress-processors/src/test/java/org/apache/nifi/processors/compress/TestModifyCompression.java +++ b/nifi-extension-bundles/nifi-compress-bundle/nifi-compress-processors/src/test/java/org/apache/nifi/processors/compress/TestModifyCompression.java @@ -248,7 +248,6 @@ public void testDeflateDecompress() throws Exception { runner.assertAllFlowFilesTransferred(ModifyCompression.REL_SUCCESS, 1); MockFlowFile flowFile = runner.getFlowFilesForRelationship(ModifyCompression.REL_SUCCESS).getFirst(); - System.err.println(new String(flowFile.toByteArray())); flowFile.assertContentEquals(getSamplePath("SampleFile.txt")); flowFile.assertAttributeEquals(CoreAttributes.FILENAME.key(), "SampleFile.txt"); } diff --git a/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcClobReadable.java b/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcClobReadable.java index 67f612cd7234..dc13406505b4 100644 --- a/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcClobReadable.java +++ b/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcClobReadable.java @@ -125,7 +125,6 @@ private void validateClob(String someClob) throws SQLException, ClassNotFoundExc final byte[] serializedBytes = outStream.toByteArray(); assertNotNull(serializedBytes); - System.out.println("Avro serialized result size in bytes: " + serializedBytes.length); st.close(); con.close(); @@ -140,7 +139,6 @@ private void validateClob(String someClob) throws SQLException, ClassNotFoundExc while (dataFileReader.hasNext()) { record = dataFileReader.next(record); assertEquals(someClob, record.get("SOMECLOB").toString(), "Unreadable code for this Clob value."); - System.out.println(record); } } } diff --git a/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java b/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java index 3a0cdae22418..1713179a7941 100644 --- a/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java +++ b/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java @@ -240,24 +240,8 @@ public void testConvertToBytes() throws SQLException, IOException { final byte[] serializedBytes = outStream.toByteArray(); assertNotNull(serializedBytes); - System.out.println("Avro serialized result size in bytes: " + serializedBytes.length); st.close(); - - // Deserialize bytes to records - final InputStream instream = new ByteArrayInputStream(serializedBytes); - - final DatumReader datumReader = new GenericDatumReader<>(); - try (final DataFileStream dataFileReader = new DataFileStream<>(instream, datumReader)) { - GenericRecord record = null; - while (dataFileReader.hasNext()) { - // Reuse record object by passing it to next(). This saves us from - // allocating and garbage collecting many objects for files with - // many items. - record = dataFileReader.next(record); - System.out.println(record); - } - } } diff --git a/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcHugeStream.java b/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcHugeStream.java index e5e416078949..f20dfb0fd06f 100644 --- a/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcHugeStream.java +++ b/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcHugeStream.java @@ -121,7 +121,6 @@ public void readSend2StreamHuge_FileBased() throws ClassNotFoundException, SQLEx record = dataFileReader.next(record); recordsFromStream += 1; } - System.out.println("total nr of records from stream: " + recordsFromStream); assertEquals(nrOfRows, recordsFromStream); } } @@ -140,10 +139,6 @@ record = dataFileReader.next(record); static public void loadTestData2Database(Connection con, int nrOfPersons, int nrOfProducts, int nrOfRels) throws ClassNotFoundException, SQLException { - System.out.println(createRandomName()); - System.out.println(createRandomName()); - System.out.println(createRandomName()); - final Statement st = con.createStatement(); // tables may not exist, this is not serious problem. diff --git a/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcTypesH2.java b/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcTypesH2.java index 7527481349c3..0702d07d4264 100644 --- a/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcTypesH2.java +++ b/nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcTypesH2.java @@ -16,21 +16,15 @@ */ package org.apache.nifi.util.db; -import org.apache.avro.file.DataFileStream; -import org.apache.avro.generic.GenericDatumReader; -import org.apache.avro.generic.GenericRecord; -import org.apache.avro.io.DatumReader; import org.apache.nifi.util.file.FileUtils; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.File; import java.io.IOException; -import java.io.InputStream; import java.nio.file.Files; import java.sql.Connection; import java.sql.DriverManager; @@ -84,7 +78,7 @@ public void afterEach() throws IOException { } @Test - public void testSQLTypesMapping() throws ClassNotFoundException, SQLException, IOException { + public void testSQLTypesMapping() throws SQLException, IOException { final Connection con = createConnection(dbPath); final Statement st = con.createStatement(); @@ -106,26 +100,9 @@ public void testSQLTypesMapping() throws ClassNotFoundException, SQLException, I final byte[] serializedBytes = outStream.toByteArray(); Assertions.assertNotNull(serializedBytes); - System.out.println("Avro serialized result size in bytes: " + serializedBytes.length); st.close(); con.close(); - - // Deserialize bytes to records - - final InputStream instream = new ByteArrayInputStream(serializedBytes); - - final DatumReader datumReader = new GenericDatumReader<>(); - try (final DataFileStream dataFileReader = new DataFileStream<>(instream, datumReader)) { - GenericRecord record = null; - while (dataFileReader.hasNext()) { - // Reuse record object by passing it to next(). This saves us from - // allocating and garbage collecting many objects for files with - // many items. - record = dataFileReader.next(record); - System.out.println(record); - } - } } // verify H2 driver loading and get Connections works diff --git a/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java b/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java index 581ec9a97762..70e7a20103e1 100644 --- a/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java +++ b/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java @@ -58,6 +58,8 @@ import org.apache.nifi.serialization.record.type.RecordDataType; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIfSystemProperty; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import static org.junit.jupiter.api.Assertions.assertArrayEquals; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -67,6 +69,7 @@ import static org.junit.jupiter.api.Assertions.fail; public class TestAvroTypeUtil { + private static final Logger logger = LoggerFactory.getLogger(TestAvroTypeUtil.class); @Test @EnabledIfSystemProperty( @@ -104,7 +107,7 @@ public void testCreateAvroRecordPerformance() throws IOException { } final long millis = System.currentTimeMillis() - start; - System.out.println(millis); + logger.info("{}", millis); } } diff --git a/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/test/java/org/apache/nifi/schema/validation/TestStandardSchemaValidator.java b/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/test/java/org/apache/nifi/schema/validation/TestStandardSchemaValidator.java index a35d436f5000..1303412c15e7 100644 --- a/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/test/java/org/apache/nifi/schema/validation/TestStandardSchemaValidator.java +++ b/nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/test/java/org/apache/nifi/schema/validation/TestStandardSchemaValidator.java @@ -343,7 +343,6 @@ public void testExtraFields() { assertEquals(1, validationErrors.size()); final ValidationError validationError = validationErrors.iterator().next(); assertEquals("/name", validationError.getFieldName().get()); - System.out.println(validationError); } diff --git a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/FetchGCSObjectIT.java b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/FetchGCSObjectIT.java index 148ccad3571f..18e817284b85 100644 --- a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/FetchGCSObjectIT.java +++ b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/FetchGCSObjectIT.java @@ -20,6 +20,8 @@ import org.apache.nifi.util.MockFlowFile; import org.apache.nifi.util.TestRunner; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.util.Collections; import java.util.HashMap; @@ -35,6 +37,7 @@ public class FetchGCSObjectIT extends AbstractGCSIT { static final String KEY = "delete-me"; static final byte[] CONTENT = {10, 11, 12}; + private static final Logger logger = LoggerFactory.getLogger(FetchGCSObjectIT.class); @Test public void testSimpleFetch() throws Exception { @@ -60,7 +63,7 @@ public void testSimpleFetch() throws Exception { ff.assertAttributeNotExists(StorageAttributes.ENCRYPTION_SHA256_ATTR); for (final Map.Entry entry : ff.getAttributes().entrySet()) { - System.out.println(entry.getKey() + ":" + entry.getValue()); + logger.info("{}:{}", entry.getKey(), entry.getValue()); } } diff --git a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/PutGCSObjectIT.java b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/PutGCSObjectIT.java index 77d68688cacf..e435ee85ad88 100644 --- a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/PutGCSObjectIT.java +++ b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/PutGCSObjectIT.java @@ -22,6 +22,8 @@ import org.apache.nifi.util.MockFlowFile; import org.apache.nifi.util.TestRunner; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.util.Map; @@ -32,6 +34,7 @@ * Integration tests for {@link PutGCSObject} which actually use Google Cloud resources. */ public class PutGCSObjectIT extends AbstractGCSIT { + private static final Logger logger = LoggerFactory.getLogger(PutGCSObjectIT.class); private static final String KEY = "delete-me"; private static final byte[] CONTENT = {12, 13, 14}; @@ -52,7 +55,7 @@ public void testSimplePut() throws Exception { flowFile.assertAttributeNotExists(ENCRYPTION_ALGORITHM_ATTR); for (Map.Entry entry : flowFile.getAttributes().entrySet()) { - System.out.println(entry.getKey() + ":" + entry.getValue()); + logger.info("{}:{}", entry.getKey(), entry.getValue()); } } @@ -74,7 +77,7 @@ public void testEncryptedPut() throws Exception { flowFile.assertAttributeExists(ENCRYPTION_ALGORITHM_ATTR); for (Map.Entry entry : flowFile.getAttributes().entrySet()) { - System.out.println(entry.getKey() + ":" + entry.getValue()); + logger.info("{}:{}", entry.getKey(), entry.getValue()); } } diff --git a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/AbstractTestRecordReaderWriter.java b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/AbstractTestRecordReaderWriter.java index 2d4684df23fd..2b38c27544c9 100644 --- a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/AbstractTestRecordReaderWriter.java +++ b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/AbstractTestRecordReaderWriter.java @@ -162,7 +162,6 @@ public void testMultipleRecordsMultipleBlocksCompressed() throws IOException { final RecordReader reader = createReader(fis, journalFile.getName(), tocReader, 2048)) { for (int i = 0; i < 10; i++) { final StandardProvenanceEventRecord recovered = reader.nextRecord(); - System.out.println(recovered); assertNotNull(recovered); assertEquals(i, recovered.getEventId()); assertEquals("nifi://unit-test", recovered.getTransitUri()); @@ -204,8 +203,6 @@ public void testSkipToEvent() throws IOException { final RecordReader reader = createReader(fis, journalFile.getName(), tocReader, 2048)) { for (int i = 0; i < numEvents; i++) { - System.out.println(i); - final Optional eventOption = reader.skipToEvent(i); assertTrue(eventOption.isPresent()); assertEquals(i, eventOption.get().getEventId()); diff --git a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestEventIdFirstSchemaRecordReaderWriter.java b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestEventIdFirstSchemaRecordReaderWriter.java index 949bf07645cb..b1868eea46bf 100644 --- a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestEventIdFirstSchemaRecordReaderWriter.java +++ b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestEventIdFirstSchemaRecordReaderWriter.java @@ -28,6 +28,8 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIfSystemProperty; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.File; import java.io.FileInputStream; @@ -47,6 +49,7 @@ import static org.junit.jupiter.api.Assertions.assertNull; public class TestEventIdFirstSchemaRecordReaderWriter extends AbstractTestRecordReaderWriter { + private static final Logger logger = LoggerFactory.getLogger(TestEventIdFirstSchemaRecordReaderWriter.class); private final AtomicLong idGenerator = new AtomicLong(0L); private File journalFile; private File tocFile; @@ -452,7 +455,7 @@ public void testPerformanceOfRandomAccessReads() throws Exception { } final long ms = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - start); - System.out.println(ms + " ms total"); + logger.info("{} ms total", ms); } } diff --git a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestSchemaRecordReaderWriter.java b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestSchemaRecordReaderWriter.java index a6f18e296235..a105803ebe3b 100644 --- a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestSchemaRecordReaderWriter.java +++ b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestSchemaRecordReaderWriter.java @@ -62,8 +62,11 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIfSystemProperty; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class TestSchemaRecordReaderWriter extends AbstractTestRecordReaderWriter { + private static final Logger logger = LoggerFactory.getLogger(TestSchemaRecordReaderWriter.class); private final AtomicLong idGenerator = new AtomicLong(0L); private File journalFile; private File tocFile; @@ -110,7 +113,7 @@ public void testPerformanceOfRandomAccessReads() throws Exception { } final long ms = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - start); - System.out.println(ms + " ms total"); + logger.info("{} ms total", ms); } } @@ -307,7 +310,7 @@ public void testWritePerformance() throws IOException { final long nanos = System.nanoTime() - startNanos; final long millis = TimeUnit.NANOSECONDS.toMillis(nanos); - System.out.println("Took " + millis + " millis to write " + numEvents + " events"); + logger.info("Took {} millis to write {} events", millis, numEvents); } @Test @@ -358,7 +361,7 @@ public void testReadPerformance() throws IOException { final double seconds = millis / 1000D; final long bytesPerSecond = (long) (totalRecordBytes / seconds); final long megaBytesPerSecond = bytesPerSecond / 1024 / 1024; - System.out.println("Took " + millis + " millis to read " + numEvents + " events or " + megaBytesPerSecond + " MB/sec"); + logger.info("Took {} millis to read {} events or {} MB/sec", millis, numEvents, megaBytesPerSecond); } diff --git a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/store/TestPartitionedWriteAheadEventStore.java b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/store/TestPartitionedWriteAheadEventStore.java index 39f7406b8966..b01c1c7b3e11 100644 --- a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/store/TestPartitionedWriteAheadEventStore.java +++ b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/store/TestPartitionedWriteAheadEventStore.java @@ -38,6 +38,8 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIfSystemProperty; import org.mockito.Mockito; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.File; import java.io.IOException; @@ -63,6 +65,7 @@ import static org.mockito.Mockito.when; public class TestPartitionedWriteAheadEventStore { + private static final Logger logger = LoggerFactory.getLogger(TestPartitionedWriteAheadEventStore.class); private static final RecordWriterFactory writerFactory = (file, idGen, compress, createToc) -> RecordWriters.newSchemaRecordWriter(file, idGen, compress, createToc); private static final RecordReaderFactory readerFactory = (file, logs, maxChars) -> RecordReaders.newRecordReader(file, logs, maxChars); @@ -108,7 +111,7 @@ private void time(final Callable task, final String taskDescription) throws E task.call(); final long nanos = System.nanoTime() - start; final long millis = TimeUnit.NANOSECONDS.toMillis(nanos); - System.out.println("Took " + millis + " ms to " + taskDescription); + logger.info("Took {} ms to {}", millis, taskDescription); } @Test diff --git a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/store/iterator/TestSelectiveRecordReaderEventIterator.java b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/store/iterator/TestSelectiveRecordReaderEventIterator.java index 7451f153e42f..3c96b8c7494c 100644 --- a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/store/iterator/TestSelectiveRecordReaderEventIterator.java +++ b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/store/iterator/TestSelectiveRecordReaderEventIterator.java @@ -45,8 +45,11 @@ import org.apache.nifi.provenance.toc.TocWriter; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIfSystemProperty; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class TestSelectiveRecordReaderEventIterator { + private static final Logger logger = LoggerFactory.getLogger(TestSelectiveRecordReaderEventIterator.class); private RecordWriter createWriter(final File file, final TocWriter tocWriter, final boolean compressed, final int uncompressedBlockSize) throws IOException { return new EventIdFirstSchemaRecordWriter(file, new AtomicLong(0L), tocWriter, compressed, uncompressedBlockSize, IdentifierLookup.EMPTY); @@ -146,7 +149,7 @@ public void testPerformanceOfRandomAccessReads() throws Exception { } final long ms = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - start); - System.out.println(ms + " ms total"); + logger.info("{} ms total", ms); } } diff --git a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-volatile-provenance-repository/src/test/java/org/apache/nifi/provenance/TestVolatileProvenanceRepository.java b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-volatile-provenance-repository/src/test/java/org/apache/nifi/provenance/TestVolatileProvenanceRepository.java index 2e7bb77b0b76..94a6f563b8f2 100644 --- a/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-volatile-provenance-repository/src/test/java/org/apache/nifi/provenance/TestVolatileProvenanceRepository.java +++ b/nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-volatile-provenance-repository/src/test/java/org/apache/nifi/provenance/TestVolatileProvenanceRepository.java @@ -116,9 +116,6 @@ public void testIndexAndCompressOnRolloverAndSubsequentSearchAsync() throws Inte } assertEquals(10, submission.getResult().getMatchingEvents().size()); - for (final ProvenanceEventRecord match : submission.getResult().getMatchingEvents()) { - System.out.println(match); - } } @Test diff --git a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestCompressContent.java b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestCompressContent.java index a1cb5feadcf9..a2c169041231 100644 --- a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestCompressContent.java +++ b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestCompressContent.java @@ -260,7 +260,6 @@ public void testDeflateDecompress() throws Exception { runner.assertAllFlowFilesTransferred(CompressContent.REL_SUCCESS, 1); MockFlowFile flowFile = runner.getFlowFilesForRelationship(CompressContent.REL_SUCCESS).get(0); - System.err.println(new String(flowFile.toByteArray())); flowFile.assertContentEquals(Paths.get("src/test/resources/CompressedData/SampleFile.txt")); flowFile.assertAttributeEquals("filename", "SampleFile.txt"); } diff --git a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestDistributeLoad.java b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestDistributeLoad.java index 6340f76da25b..b2e02c3dd797 100644 --- a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestDistributeLoad.java +++ b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestDistributeLoad.java @@ -106,7 +106,6 @@ public void testNextAvailable() { testRunner.assertQueueEmpty(); for (int i = 1; i <= 100; i++) { - System.out.println(i); testRunner.assertTransferCount(String.valueOf(i), (i == 50) ? 0 : 1); } } diff --git a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteProcess.java b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteProcess.java index dc04c4f4eafb..4deb01ccbe0e 100644 --- a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteProcess.java +++ b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteProcess.java @@ -97,8 +97,6 @@ public void testEcho() { final List flowFiles = runner.getFlowFilesForRelationship(ExecuteProcess.REL_SUCCESS); for (final MockFlowFile flowFile : flowFiles) { - System.out.println(flowFile); - System.out.println(new String(flowFile.toByteArray())); flowFile.assertAttributeNotExists(CoreAttributes.MIME_TYPE.key()); } } @@ -145,14 +143,12 @@ public void testBigBinaryInputData() { runner.setProperty(ExecuteProcess.WORKING_DIR, workingDirName); File inFile = new File(workingDirName, testFile); - System.out.println(inFile.getAbsolutePath()); runner.run(); final List flowFiles = runner.getFlowFilesForRelationship(ExecuteProcess.REL_SUCCESS); long totalFlowFilesSize = 0; for (final MockFlowFile flowFile : flowFiles) { - System.out.println(flowFile); totalFlowFilesSize += flowFile.getSize(); } @@ -175,9 +171,6 @@ public void testBigInputSplit() { runner.setProperty(ExecuteProcess.BATCH_DURATION, "150 millis"); File inFile = new File(workingDirName, testFile); - System.out.println(inFile.getAbsolutePath()); - - // runner.run(1,false,true); ProcessContext processContext = runner.getProcessContext(); diff --git a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java index e490c46c26bb..c8db5c533ff6 100644 --- a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java +++ b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java @@ -956,7 +956,6 @@ public void testLookupArrayKeyNotInLRS() throws InitializationException, IOExcep runner.assertAllFlowFilesTransferred(LookupRecord.REL_UNMATCHED); final MockFlowFile out = runner.getFlowFilesForRelationship(LookupRecord.REL_UNMATCHED).get(0); - System.out.println(out.getContent()); out.assertContentEquals(new File("src/test/resources/TestLookupRecord/lookup-array-output-unmatched.json").toPath()); } diff --git a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestModifyBytes.java b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestModifyBytes.java index b94ed6374f2e..2a2c541ff422 100644 --- a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestModifyBytes.java +++ b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestModifyBytes.java @@ -23,7 +23,6 @@ import java.io.File; import java.io.IOException; -import java.nio.charset.StandardCharsets; import java.nio.file.Path; import java.nio.file.Paths; import java.util.HashMap; @@ -89,8 +88,6 @@ public void testRemoveHeader() throws IOException { runner.assertAllFlowFilesTransferred(ModifyBytes.REL_SUCCESS, 1); final MockFlowFile out = runner.getFlowFilesForRelationship(ModifyBytes.REL_SUCCESS).get(0); - final String outContent = new String(out.toByteArray(), StandardCharsets.UTF_8); - System.out.println(outContent); out.assertContentEquals(noHeaderFile); } @@ -107,8 +104,6 @@ public void testRemoveHeaderEL() throws IOException { runner.assertAllFlowFilesTransferred(ModifyBytes.REL_SUCCESS, 1); final MockFlowFile out = runner.getFlowFilesForRelationship(ModifyBytes.REL_SUCCESS).get(0); - final String outContent = new String(out.toByteArray(), StandardCharsets.UTF_8); - System.out.println(outContent); out.assertContentEquals(noHeaderFile); } @@ -123,8 +118,6 @@ public void testKeepFooter() throws IOException { runner.assertAllFlowFilesTransferred(ModifyBytes.REL_SUCCESS, 1); final MockFlowFile out = runner.getFlowFilesForRelationship(ModifyBytes.REL_SUCCESS).get(0); - final String outContent = new String(out.toByteArray(), StandardCharsets.UTF_8); - System.out.println(outContent); out.assertContentEquals("<<