Supply a hint arrow schema for casting Parquet field types during scans #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so as to avoid a potential schema mismatch resulting from upcasting arrow 8 and 16 bit integers to Iceberg 32 bit integer type.
gruuya
commented
Dec 17, 2024
Comment on lines
+199
to
+204
| if task.schema.as_struct().fields().iter().any(|field| { | ||
| matches!( | ||
| field.field_type.as_ref(), | ||
| Type::Primitive(PrimitiveType::Int) | ||
| ) | ||
| }) { |
There was a problem hiding this comment.
Maybe this should be done only if the field with this type is also one of the projected ones.
This was referenced Dec 18, 2024
|
Making this a draft as the upstream dependency is also a draft atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so as to avoid a potential schema mismatch resulting from upcasting arrow 8 and 16 bit integers to Iceberg 32 bit integer type.
This is one way to resolve #813. Note that this is dependent on apache/arrow-rs#6892 getting merged (and picked up) first.
I still need to think of a proper test case for this too.
Closes #813.