Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the integration tests work on OSX #719

Open
Fokko opened this issue Nov 27, 2024 · 3 comments
Open

Make the integration tests work on OSX #719

Fokko opened this issue Nov 27, 2024 · 3 comments
Assignees

Comments

@Fokko
Copy link
Contributor

Fokko commented Nov 27, 2024

When I run make test, all the docker-based tests fail because the 172.* does not resolve. I think this is the difference between OSX and Linux when it comes to docker networking. I think it would be better to expose the ports on the host machine and use 127.0.0.1 instead as this should also run on Linux.

running 3 tests
test tests::gcs_exists has been running for over 60 seconds
test tests::gcs_read has been running for over 60 seconds
test tests::gcs_write has been running for over 60 seconds
test tests::gcs_exists ... FAILED
test tests::gcs_read ... FAILED
test tests::gcs_write ... FAILED

failures:

---- tests::gcs_exists stdout ----
thread 'tests::gcs_exists' panicked at crates/iceberg/tests/file_io_gcs_test.rs:67:14:
called `Result::unwrap()` on an `Err` value: error sending request for url (http://172.20.0.2:4443/storage/v1/b)

Caused by:
    0: client error (Connect)
    1: tcp connect error: Operation timed out (os error 60)
    2: Operation timed out (os error 60)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- tests::gcs_read stdout ----
thread 'tests::gcs_read' panicked at crates/iceberg/tests/file_io_gcs_test.rs:67:14:
called `Result::unwrap()` on an `Err` value: error sending request for url (http://172.20.0.2:4443/storage/v1/b)

Caused by:
    0: client error (Connect)
    1: tcp connect error: Operation timed out (os error 60)
    2: Operation timed out (os error 60)

---- tests::gcs_write stdout ----
thread 'tests::gcs_write' panicked at crates/iceberg/tests/file_io_gcs_test.rs:67:14:
called `Result::unwrap()` on an `Err` value: error sending request for url (http://172.20.0.2:4443/storage/v1/b)

Caused by:
    0: client error (Connect)
    1: tcp connect error: Operation timed out (os error 60)
    2: Operation timed out (os error 60)
@liurenjie1024
Copy link
Contributor

Are you using docker or orbstack? I used orbstack and it works well before.

@Fokko
Copy link
Contributor Author

Fokko commented Nov 27, 2024

I'm using native docker, I might give orbstack a go then. I know that @c-thiel is using Podmon, so maybe we should make the docker bin configurable.

@Fokko Fokko self-assigned this Nov 29, 2024
@Fokko
Copy link
Contributor Author

Fokko commented Dec 2, 2024

LOL, it works now. It looks like it is picking up some credentials. After running mv ~/.aws/ ~/.aws.backup/ the error around the invalid token is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants