Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Partition Specs can only contain primitive types #718

Open
c-thiel opened this issue Nov 27, 2024 · 1 comment · May be fixed by #780
Open

Ensure Partition Specs can only contain primitive types #718

c-thiel opened this issue Nov 27, 2024 · 1 comment · May be fixed by #780
Labels
good first issue Good for newcomers

Comments

@c-thiel
Copy link
Collaborator

c-thiel commented Nov 27, 2024

Following the discussion here: #349 (comment) and the spec, partitions must only produce primitive types.

This is currently not guranteed, neither by deserialization nor for add_unbound_field. At least adding a void transform can result in complex types.
@c-thiel c-thiel mentioned this issue Nov 27, 2024
Merged
@c-thiel c-thiel added the good first issue Good for newcomers label Nov 28, 2024
@Lordworms Lordworms linked a pull request Dec 12, 2024 that will close this issue
Open
@liurenjie1024
Copy link
Contributor

Instead of ensuring primitive types only, should we add check in Transform, e.g. check each transform supports targeting type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure Partition Specs can only contain primitive types Lordworms/iceberg-rust
2 participants
@liurenjie1024 @c-thiel