Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading and writing snapshot properties #367

Closed
brianfromoregon opened this issue Feb 5, 2024 · 5 comments
Closed

Support reading and writing snapshot properties #367

brianfromoregon opened this issue Feb 5, 2024 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@brianfromoregon
Copy link

Feature Request / Improvement

snapshots.py has a Snapshot and Summary class but they don't seem to be user facing. I'd like to read/write custom properties in the snapshot's summary map. When writing a property, it should be possible to do so atomically with a data write (in same snapshot)

@Fokko Fokko added the documentation Improvements or additions to documentation label Feb 5, 2024
@Fokko
Copy link
Contributor

Fokko commented Feb 5, 2024

Hey @brianfromoregon, I agree. For writing, I left a comment in #368 For reading, I think we're missing some documentation since it is already possible:

if snapshot := tbl.current_snapshot():
    snapshot.summary.get("watermark:raw.log_source")

@brianfromoregon
Copy link
Author

brianfromoregon commented Feb 9, 2024

There is a test in the repo called test_glue.py called test_commit_table_properties which modifies table properties in a transaction.

I think a successful completion of this issue could include a new test called test_commit_snapshot_properties that has the same basic structure but is modifying snapshot properties (within summary field) instead of table properties.

@Gowthami03B
Copy link
Contributor

@brianfromoregon @Fokko can I take a stab at this?

@Gowthami03B
Copy link
Contributor

#419

@sungwy sungwy closed this as completed Mar 26, 2024
@sungwy
Copy link
Collaborator

sungwy commented Mar 26, 2024

Completed by #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants