Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] In the Gravitino CLI add an unknown tags give no error #5930

Closed
justinmclean opened this issue Dec 20, 2024 · 4 comments · Fixed by #5978
Closed

[Improvement] In the Gravitino CLI add an unknown tags give no error #5930

justinmclean opened this issue Dec 20, 2024 · 4 comments · Fixed by #5978
Assignees
@Abyss-lord
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Adding a tag that doesn;t exist will give no error and no tag is added. Example command and output:

gcli tag set --metalake metalake_demo --name catalog_postgres --tag unknown -i
catalog_postgres now tagged with

How should we improve?

The output could be improved e.g. "catalog_postgres now tagged with nothing". However, this seems more like a Java API issue in that NoSuchTag exception or similar should have been thrown.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Dec 20, 2024
@mchades
Copy link
Contributor

mchades commented Dec 20, 2024

This is an intentional behavior, for non-existent tags, its behavior is on-op. I think we just need to improve the documentation. WDYT? @jerryshao

@justinmclean justinmclean changed the title [Improvement] In teh Gravitino CLI add an unknown tags give no error [Improvement] In the Gravitino CLI add an unknown tags give no error Dec 20, 2024
@jerryshao
Copy link
Contributor

Yes, it is by design, otherwise it will be a high-cost operation to check the validity of tags. I can improve the docs if required.

@justinmclean
Copy link
Member Author

Other tag commands do check if the tag exists e.g. setting a property on a tag

@Abyss-lord
Copy link
Contributor

I would like to work on it.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 25, 2024
@Abyss-lord
[apache#5930] improvement(CLI): improve unknown tag output.
cea8d1d 
Improve output when CLI add an unknown tags.
@Abyss-lord Abyss-lord mentioned this issue Dec 25, 2024
Merged
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 29, 2024
@Abyss-lord
[apache#5930] improvement(CLI): improve unknown tag output. (apache#5978
e1acf63 
)

### What changes were proposed in this pull request?

Improve output when CLI add an unknown tags.

### Why are the changes needed?

Fix: apache#5930 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

local test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5930] improvement(CLI): improve unknown tag output. Abyss-lord/gravitino
4 participants
@justinmclean @jerryshao @mchades @Abyss-lord