Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](profile) Fix merge profile failed due to NonZeroCounter #47465

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhiqiang-hhhh
Copy link
Contributor

What problem does this PR solve?

orgCounter could be null if counter structure is changed
change of counter structure happens when NonZeroCounter is involved.
So here we have to ignore the counter if it is not found in the profile.

Related PR: #47070

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32298 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bb6b44f1b7084564a77d92bb03c6733bf9ee1706, data reload: false

------ Round 1 ----------------------------------
q1	17586	5584	5414	5414
q2	2047	311	175	175
q3	10555	1317	741	741
q4	10264	966	545	545
q5	8426	2378	2182	2182
q6	198	168	131	131
q7	906	748	613	613
q8	9230	1379	1171	1171
q9	5533	4873	4929	4873
q10	6831	2314	1890	1890
q11	469	278	252	252
q12	338	359	213	213
q13	17785	3685	3079	3079
q14	224	221	213	213
q15	506	475	480	475
q16	632	623	584	584
q17	579	866	329	329
q18	7245	6455	6346	6346
q19	1434	954	539	539
q20	313	317	197	197
q21	2806	2228	2017	2017
q22	364	331	319	319
Total cold run time: 104271 ms
Total hot run time: 32298 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5521	5457	5497	5457
q2	232	329	235	235
q3	2231	2667	2269	2269
q4	1407	1838	1402	1402
q5	4318	4756	4628	4628
q6	168	166	129	129
q7	2078	1952	1880	1880
q8	2738	2818	2727	2727
q9	7239	7196	7220	7196
q10	3023	3246	2727	2727
q11	578	508	495	495
q12	663	742	626	626
q13	3657	3916	3313	3313
q14	289	301	286	286
q15	518	469	458	458
q16	639	695	652	652
q17	1211	1735	1274	1274
q18	7690	7561	7232	7232
q19	805	1156	1056	1056
q20	2020	2079	1894	1894
q21	5764	5216	5055	5055
q22	596	577	586	577
Total cold run time: 53385 ms
Total hot run time: 51568 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184843 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bb6b44f1b7084564a77d92bb03c6733bf9ee1706, data reload: false

query1	973	381	371	371
query2	6519	2083	1985	1985
query3	6809	216	216	216
query4	33385	23710	22925	22925
query5	4353	617	459	459
query6	283	197	179	179
query7	4608	504	317	317
query8	294	238	223	223
query9	9642	2716	2725	2716
query10	486	315	245	245
query11	18250	15122	14855	14855
query12	147	105	105	105
query13	1667	527	420	420
query14	10245	7093	7355	7093
query15	228	188	187	187
query16	7625	623	458	458
query17	1642	738	596	596
query18	1870	400	318	318
query19	229	193	157	157
query20	115	111	116	111
query21	214	122	103	103
query22	4358	4315	4282	4282
query23	33760	32851	33181	32851
query24	6680	2318	2359	2318
query25	495	451	377	377
query26	1213	272	151	151
query27	2025	471	354	354
query28	5186	2477	2450	2450
query29	665	557	432	432
query30	227	204	171	171
query31	960	878	794	794
query32	86	65	55	55
query33	536	351	295	295
query34	758	843	507	507
query35	778	807	743	743
query36	984	1017	950	950
query37	129	104	79	79
query38	4203	4235	4045	4045
query39	1461	1419	1445	1419
query40	208	111	98	98
query41	58	51	56	51
query42	129	101	102	101
query43	509	535	512	512
query44	1353	805	834	805
query45	183	172	165	165
query46	857	1044	640	640
query47	1779	1837	1772	1772
query48	381	398	321	321
query49	796	489	402	402
query50	631	674	404	404
query51	4223	4157	4105	4105
query52	109	105	90	90
query53	226	274	192	192
query54	487	486	427	427
query55	80	81	82	81
query56	269	245	240	240
query57	1158	1148	1091	1091
query58	256	238	241	238
query59	3039	3153	2865	2865
query60	281	264	248	248
query61	141	113	116	113
query62	786	692	650	650
query63	219	197	189	189
query64	4458	1025	640	640
query65	3222	3152	3203	3152
query66	1075	407	302	302
query67	16027	15713	15391	15391
query68	4325	839	551	551
query69	448	298	315	298
query70	1184	1139	1144	1139
query71	376	292	260	260
query72	5813	3887	3849	3849
query73	660	742	362	362
query74	9840	9293	8878	8878
query75	3153	3168	2664	2664
query76	3161	1193	778	778
query77	459	375	276	276
query78	9951	9929	9303	9303
query79	3123	822	591	591
query80	824	580	441	441
query81	520	268	237	237
query82	725	156	123	123
query83	173	166	151	151
query84	251	94	71	71
query85	808	374	304	304
query86	415	322	310	310
query87	4405	4441	4262	4262
query88	5079	2180	2142	2142
query89	385	326	288	288
query90	1819	191	199	191
query91	135	139	104	104
query92	65	59	52	52
query93	2785	872	551	551
query94	766	425	298	298
query95	334	278	305	278
query96	494	610	277	277
query97	2793	2858	2769	2769
query98	221	206	199	199
query99	1294	1347	1249	1249
Total cold run time: 283812 ms
Total hot run time: 184843 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bb6b44f1b7084564a77d92bb03c6733bf9ee1706, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.24	0.07	0.06
query4	1.62	0.11	0.11
query5	0.40	0.41	0.41
query6	1.13	0.65	0.66
query7	0.03	0.02	0.02
query8	0.03	0.03	0.03
query9	0.58	0.48	0.51
query10	0.56	0.57	0.56
query11	0.15	0.10	0.11
query12	0.13	0.11	0.11
query13	0.61	0.61	0.59
query14	2.70	2.72	2.74
query15	0.89	0.83	0.84
query16	0.38	0.39	0.38
query17	1.06	0.96	0.96
query18	0.22	0.21	0.20
query19	1.99	1.86	1.97
query20	0.01	0.02	0.01
query21	15.34	0.96	0.60
query22	0.76	1.04	0.71
query23	15.04	1.41	0.53
query24	3.18	1.34	1.45
query25	0.15	0.13	0.12
query26	0.28	0.15	0.13
query27	0.06	0.04	0.04
query28	14.03	1.00	0.43
query29	12.57	3.91	3.27
query30	0.26	0.09	0.06
query31	2.82	0.57	0.39
query32	3.22	0.54	0.46
query33	3.00	3.00	3.08
query34	16.62	5.15	4.53
query35	4.48	4.50	4.51
query36	0.64	0.50	0.47
query37	0.10	0.07	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.8 s
Total hot run time: 31.04 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants