-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](compaction) Should do_lease for full compaction #47436
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
f34e86a
to
140f1b3
Compare
run buildall |
140f1b3
to
52e0f38
Compare
run buildall |
TPC-H: Total hot run time: 32121 ms
|
TPC-DS: Total hot run time: 184763 ms
|
ClickBench: Total hot run time: 31.53 s
|
TeamCity be ut coverage result: |
run p0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run p0 |
1 similar comment
run p0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Problem Summary:
Manually triggered full compaction may fail with the msg "there is no running compaction".
We should do lease for full compaction. Otherwise, if full compaction lasts longer than
config::lease_compaction_interval_seconds * 4 = 80s
, the later compaction on same tablet will remove the full compaction from tablet's job in MS.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)