Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](export) fix error in show export outfile info column #46850

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Jan 12, 2025

What problem does this PR solve?

There is a error in OutfileInfo column in SHOW EXPORT result:

before:

"fileSize":"33554432bytes"

after:

"fileSize":"33554432"

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32823 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1bbf510cc443d59428ee2e71211b9c07f2d9a6b5, data reload: false

------ Round 1 ----------------------------------
q1	17578	6194	6058	6058
q2	2053	304	182	182
q3	10420	1216	740	740
q4	10236	875	447	447
q5	7725	2211	1999	1999
q6	212	178	147	147
q7	908	751	603	603
q8	9240	1396	1229	1229
q9	5148	4911	4879	4879
q10	6802	2330	1867	1867
q11	464	283	271	271
q12	349	361	224	224
q13	17766	3647	3101	3101
q14	234	225	221	221
q15	547	506	499	499
q16	650	621	588	588
q17	581	853	334	334
q18	6926	6421	6414	6414
q19	1379	953	567	567
q20	316	316	196	196
q21	3011	2214	1952	1952
q22	367	334	305	305
Total cold run time: 102912 ms
Total hot run time: 32823 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6271	6251	6217	6217
q2	238	336	245	245
q3	2237	2705	2319	2319
q4	1404	1814	1321	1321
q5	4302	4752	4755	4752
q6	191	175	138	138
q7	2087	2014	1814	1814
q8	2608	2837	2712	2712
q9	7492	7342	7330	7330
q10	3061	3282	2731	2731
q11	592	517	504	504
q12	714	765	638	638
q13	3446	3862	3198	3198
q14	312	298	282	282
q15	552	532	498	498
q16	677	693	657	657
q17	1234	1744	1265	1265
q18	7676	7477	7382	7382
q19	802	1052	1154	1052
q20	1994	2009	1936	1936
q21	5663	5100	4961	4961
q22	643	623	610	610
Total cold run time: 54196 ms
Total hot run time: 52562 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196061 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1bbf510cc443d59428ee2e71211b9c07f2d9a6b5, data reload: false

query1	1324	971	941	941
query2	6336	2373	2350	2350
query3	11042	4735	4744	4735
query4	32935	23784	23389	23389
query5	3797	606	481	481
query6	277	206	174	174
query7	3974	482	304	304
query8	293	246	224	224
query9	9154	2708	2716	2708
query10	482	311	250	250
query11	17843	15270	15375	15270
query12	157	108	107	107
query13	1579	520	405	405
query14	10707	6550	7361	6550
query15	248	208	192	192
query16	8245	629	481	481
query17	1582	785	610	610
query18	2132	425	336	336
query19	213	198	166	166
query20	177	118	108	108
query21	211	136	110	110
query22	4686	4512	4357	4357
query23	34177	33642	33643	33642
query24	6253	2254	2346	2254
query25	488	477	404	404
query26	727	280	157	157
query27	2008	459	336	336
query28	5297	2486	2465	2465
query29	620	557	418	418
query30	212	189	154	154
query31	960	893	854	854
query32	74	63	53	53
query33	489	373	301	301
query34	778	861	498	498
query35	802	846	735	735
query36	1017	1055	933	933
query37	136	100	87	87
query38	4303	4147	4226	4147
query39	1527	1496	1442	1442
query40	200	116	103	103
query41	53	49	53	49
query42	128	98	101	98
query43	517	539	495	495
query44	1320	814	818	814
query45	183	181	177	177
query46	867	1064	650	650
query47	1882	1889	1815	1815
query48	388	403	312	312
query49	714	501	415	415
query50	635	675	388	388
query51	7090	7047	6985	6985
query52	103	99	92	92
query53	224	255	183	183
query54	479	483	413	413
query55	86	77	78	77
query56	248	258	238	238
query57	1217	1197	1138	1138
query58	244	227	242	227
query59	3334	3402	3427	3402
query60	279	267	268	267
query61	117	131	118	118
query62	833	783	721	721
query63	238	189	190	189
query64	3143	1043	665	665
query65	3327	3230	3352	3230
query66	783	479	305	305
query67	16243	15682	15565	15565
query68	7829	752	525	525
query69	483	289	259	259
query70	1188	1138	1125	1125
query71	439	305	258	258
query72	6531	3837	3897	3837
query73	657	749	357	357
query74	10809	8952	8995	8952
query75	4186	3111	2675	2675
query76	3586	1157	761	761
query77	762	362	274	274
query78	10142	9971	9348	9348
query79	3746	806	591	591
query80	700	525	452	452
query81	513	272	235	235
query82	616	148	123	123
query83	204	176	156	156
query84	293	93	78	78
query85	800	340	366	340
query86	395	314	290	290
query87	4426	4539	4653	4539
query88	4833	2194	2186	2186
query89	397	313	295	295
query90	1714	184	183	183
query91	132	140	103	103
query92	65	57	50	50
query93	2028	832	571	571
query94	648	402	304	304
query95	327	259	253	253
query96	502	605	279	279
query97	2854	3010	2835	2835
query98	229	196	205	196
query99	1573	1532	1372	1372
Total cold run time: 295744 ms
Total hot run time: 196061 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1bbf510cc443d59428ee2e71211b9c07f2d9a6b5, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.42	0.39	0.39
query6	1.14	0.65	0.65
query7	0.03	0.01	0.02
query8	0.03	0.03	0.04
query9	0.59	0.52	0.50
query10	0.53	0.57	0.55
query11	0.14	0.11	0.11
query12	0.14	0.10	0.12
query13	0.60	0.61	0.60
query14	2.84	2.78	2.87
query15	0.89	0.83	0.81
query16	0.40	0.39	0.39
query17	1.06	0.99	0.97
query18	0.23	0.22	0.21
query19	1.94	1.86	1.96
query20	0.01	0.01	0.02
query21	15.38	0.90	0.60
query22	0.75	0.70	0.65
query23	15.43	1.45	0.50
query24	3.22	1.80	1.73
query25	0.16	0.16	0.14
query26	0.20	0.15	0.14
query27	0.07	0.06	0.05
query28	14.62	1.45	1.05
query29	12.56	3.87	3.25
query30	0.25	0.09	0.07
query31	2.89	0.58	0.38
query32	3.22	0.55	0.47
query33	3.11	3.17	3.20
query34	16.61	5.11	4.54
query35	4.55	4.52	4.56
query36	0.66	0.51	0.49
query37	0.10	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.13 s
Total hot run time: 32.26 s

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32416 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 76f67dc8ae23b261fbfc504b4409e96da1bb6e9a, data reload: false

------ Round 1 ----------------------------------
q1	17572	6146	6064	6064
q2	2055	295	166	166
q3	10434	1226	710	710
q4	10212	880	430	430
q5	7548	2138	1930	1930
q6	207	179	148	148
q7	896	746	606	606
q8	9222	1306	1106	1106
q9	5223	4944	4866	4866
q10	6763	2295	1865	1865
q11	474	274	265	265
q12	337	357	215	215
q13	17784	3674	3103	3103
q14	243	223	230	223
q15	558	496	516	496
q16	626	620	594	594
q17	543	830	318	318
q18	7017	6299	6380	6299
q19	1215	936	544	544
q20	316	325	195	195
q21	2759	2119	1958	1958
q22	365	328	315	315
Total cold run time: 102369 ms
Total hot run time: 32416 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6253	6214	6254	6214
q2	240	331	238	238
q3	2238	2665	2303	2303
q4	1425	1810	1352	1352
q5	4313	4761	4613	4613
q6	190	181	145	145
q7	2095	1963	1843	1843
q8	2620	2749	2678	2678
q9	7197	7127	7185	7127
q10	3034	3327	2774	2774
q11	599	508	492	492
q12	668	799	629	629
q13	3442	3874	3221	3221
q14	269	306	281	281
q15	577	498	505	498
q16	651	703	632	632
q17	1236	1728	1266	1266
q18	7670	7456	7035	7035
q19	747	1070	1009	1009
q20	1943	1937	1827	1827
q21	5448	5077	4733	4733
q22	600	591	572	572
Total cold run time: 53455 ms
Total hot run time: 51482 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188667 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 76f67dc8ae23b261fbfc504b4409e96da1bb6e9a, data reload: false

query1	986	391	357	357
query2	6527	2332	2332	2332
query3	6709	210	215	210
query4	33833	23861	23585	23585
query5	4332	615	480	480
query6	301	211	193	193
query7	4637	513	308	308
query8	310	237	235	235
query9	9342	2683	2646	2646
query10	481	329	261	261
query11	18603	15159	15132	15132
query12	158	112	106	106
query13	1670	501	388	388
query14	10629	7498	7372	7372
query15	274	195	179	179
query16	8519	577	416	416
query17	1625	713	569	569
query18	2069	392	305	305
query19	241	180	151	151
query20	114	108	111	108
query21	213	123	102	102
query22	4376	4423	4266	4266
query23	33770	32904	33161	32904
query24	6385	2306	2245	2245
query25	469	444	382	382
query26	1197	280	154	154
query27	1972	457	324	324
query28	5441	2434	2372	2372
query29	658	541	410	410
query30	258	198	157	157
query31	979	843	793	793
query32	73	62	64	62
query33	521	344	305	305
query34	761	846	498	498
query35	785	842	763	763
query36	993	1005	900	900
query37	126	105	85	85
query38	4031	3988	3959	3959
query39	1495	1414	1403	1403
query40	202	115	101	101
query41	53	51	49	49
query42	123	103	106	103
query43	495	520	471	471
query44	1273	809	795	795
query45	177	178	164	164
query46	849	1022	632	632
query47	1820	1815	1776	1776
query48	386	391	321	321
query49	768	481	398	398
query50	624	635	385	385
query51	6911	6811	6855	6811
query52	100	106	88	88
query53	219	249	186	186
query54	477	472	401	401
query55	82	83	80	80
query56	272	256	241	241
query57	1169	1183	1072	1072
query58	247	240	266	240
query59	2957	3094	2894	2894
query60	289	280	259	259
query61	176	120	119	119
query62	849	766	719	719
query63	224	193	182	182
query64	3793	1036	652	652
query65	3218	3159	3175	3159
query66	1050	407	309	309
query67	15781	15570	15333	15333
query68	8009	710	524	524
query69	461	293	316	293
query70	1214	1105	1123	1105
query71	425	295	257	257
query72	6200	3843	3964	3843
query73	660	757	358	358
query74	10110	8799	8787	8787
query75	4193	3131	2649	2649
query76	3834	1154	767	767
query77	778	393	273	273
query78	10047	9897	9384	9384
query79	3158	801	579	579
query80	649	517	432	432
query81	484	275	242	242
query82	640	149	118	118
query83	167	174	151	151
query84	235	91	73	73
query85	789	345	300	300
query86	348	321	291	291
query87	4402	4451	4400	4400
query88	4174	2160	2120	2120
query89	406	323	291	291
query90	1927	188	190	188
query91	131	132	108	108
query92	74	59	54	54
query93	1117	850	533	533
query94	660	389	288	288
query95	337	268	264	264
query96	478	616	289	289
query97	2861	2913	2793	2793
query98	227	208	200	200
query99	1597	1472	1356	1356
Total cold run time: 291239 ms
Total hot run time: 188667 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.82 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 76f67dc8ae23b261fbfc504b4409e96da1bb6e9a, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.43	0.43	0.41
query6	1.14	0.66	0.65
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.50	0.50
query10	0.55	0.56	0.54
query11	0.15	0.11	0.11
query12	0.14	0.10	0.10
query13	0.61	0.61	0.59
query14	2.81	2.82	2.83
query15	0.89	0.82	0.82
query16	0.38	0.39	0.38
query17	1.07	1.04	1.04
query18	0.22	0.21	0.22
query19	1.95	1.77	1.98
query20	0.01	0.01	0.01
query21	15.38	0.98	0.60
query22	0.76	0.77	0.66
query23	15.28	1.51	0.56
query24	3.15	1.31	1.94
query25	0.10	0.15	0.21
query26	0.38	0.15	0.13
query27	0.05	0.06	0.05
query28	13.81	1.52	1.05
query29	12.59	4.09	3.43
query30	0.24	0.09	0.06
query31	2.82	0.59	0.37
query32	3.23	0.55	0.46
query33	3.08	3.09	3.17
query34	16.92	5.11	4.43
query35	4.49	4.47	4.45
query36	0.67	0.48	0.47
query37	0.10	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.04
Total cold run time: 106.38 s
Total hot run time: 31.82 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 14, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit c7c1e80 into apache:master Jan 14, 2025
26 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
### What problem does this PR solve?

There is a error in `OutfileInfo` column in `SHOW EXPORT` result:

before:
```
"fileSize":"33554432bytes"
```

after:
```
"fileSize":"33554432"
```
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
### What problem does this PR solve?

There is a error in `OutfileInfo` column in `SHOW EXPORT` result:

before:
```
"fileSize":"33554432bytes"
```

after:
```
"fileSize":"33554432"
```
yiguolei pushed a commit that referenced this pull request Jan 14, 2025
### What problem does this PR solve?

There is a error in `OutfileInfo` column in `SHOW EXPORT` result:

before:
```
"fileSize":"33554432bytes"
```

after:
```
"fileSize":"33554432"
```
morningman added a commit that referenced this pull request Jan 15, 2025
morningman added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants