[pipelineX](dependency) split different dependencies #27366
Conversation
Gabriel39
force-pushed
the
dev_1121
branch
2 times, most recently
from
cc65e79 to
6b1d7fa
Compare
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -79,37 +83,46 @@ Status AggLocalState::init(RuntimeState* state, LocalStateInfo& info) { | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| Status AggLocalState::_destroy_agg_status(vectorized::AggregateDataPtr data) { | |||
There was a problem hiding this comment.
warning: method '_destroy_agg_status' can be made static [readability-convert-member-functions-to-static]
be/src/pipeline/exec/aggregation_source_operator.h:110:
- Status _destroy_agg_status(vectorized::AggregateDataPtr data);
+ static Status _destroy_agg_status(vectorized::AggregateDataPtr data);| for (size_t i = 0; i < _shared_state->aggregate_evaluators.size(); ++i) | ||
| _shared_state->aggregate_evaluators[i]->insert_result_info( | ||
| mapped + _dependency->offsets_of_aggregate_states()[i], | ||
| for (size_t i = 0; i < shared_state.aggregate_evaluators.size(); ++i) |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| for (size_t i = 0; i < shared_state.aggregate_evaluators.size(); ++i) | |
| for (size_t i = 0; i < shared_state.aggregate_evaluators.size(); ++i) { |
be/src/pipeline/exec/aggregation_source_operator.cpp:443:
- value_columns[i].get());
+ value_columns[i].get());
+ }| @@ -175,6 +175,68 @@ void HashJoinBuildSinkLocalState::init_short_circuit_for_probe() { | |||
| p._join_op == TJoinOp::LEFT_ANTI_JOIN); | |||
| } | |||
|
|
|||
| Status HashJoinBuildSinkLocalState::_do_evaluate(vectorized::Block& block, | |||
There was a problem hiding this comment.
warning: method '_do_evaluate' can be made static [readability-convert-member-functions-to-static]
| Status HashJoinBuildSinkLocalState::_do_evaluate(vectorized::Block& block, | |
| static Status HashJoinBuildSinkLocalState::_do_evaluate(vectorized::Block& block, |
| return results; | ||
| } | ||
|
|
||
| Status HashJoinBuildSinkLocalState::_extract_join_column( |
There was a problem hiding this comment.
warning: method '_extract_join_column' can be made static [readability-convert-member-functions-to-static]
| Status HashJoinBuildSinkLocalState::_extract_join_column( | |
| static Status HashJoinBuildSinkLocalState::_extract_join_column( |
| @@ -402,6 +402,48 @@ Status HashJoinProbeOperatorX::pull(doris::RuntimeState* state, vectorized::Bloc | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| Status HashJoinProbeLocalState::_extract_join_column(vectorized::Block& block, | |||
There was a problem hiding this comment.
warning: method '_extract_join_column' can be made static [readability-convert-member-functions-to-static]
| Status HashJoinProbeLocalState::_extract_join_column(vectorized::Block& block, | |
| static Status HashJoinProbeLocalState::_extract_join_column(vectorized::Block& block, |
| @@ -93,6 +93,16 @@ class StreamingAggSinkLocalState final | |||
| Status _pre_agg_with_serialized_key(doris::vectorized::Block* in_block, | |||
| doris::vectorized::Block* out_block); | |||
| bool _should_expand_preagg_hash_tables(); | |||
| void _make_nullable_output_key(vectorized::Block* block) { | |||
There was a problem hiding this comment.
warning: method '_make_nullable_output_key' can be made static [readability-convert-member-functions-to-static]
| void _make_nullable_output_key(vectorized::Block* block) { | |
| static void _make_nullable_output_key(vectorized::Block* block) { |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
TeamCity be ut coverage result: |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TeamCity be ut coverage result: |
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
|
run buildall |
1 similar comment
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...