From 07049c8cf5a4c86f33f0b1826c7e732ada16fa0c Mon Sep 17 00:00:00 2001 From: Kazuyuki Tanimura Date: Thu, 30 Jan 2025 11:42:53 -0800 Subject: [PATCH 1/2] fix: disable ArrayRemove by default as described in the doc --- spark/src/main/scala/org/apache/comet/serde/arrays.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spark/src/main/scala/org/apache/comet/serde/arrays.scala b/spark/src/main/scala/org/apache/comet/serde/arrays.scala index db1679f22..639e698ec 100644 --- a/spark/src/main/scala/org/apache/comet/serde/arrays.scala +++ b/spark/src/main/scala/org/apache/comet/serde/arrays.scala @@ -26,7 +26,7 @@ import org.apache.comet.CometSparkSessionExtensions.withInfo import org.apache.comet.serde.QueryPlanSerde.{createBinaryExpr, exprToProto} import org.apache.comet.shims.CometExprShim -object CometArrayRemove extends CometExpressionSerde with CometExprShim { +object CometArrayRemove extends CometExpressionSerde with CometExprShim with IncompatExpr { /** Exposed for unit testing */ def isTypeSupported(dt: DataType): Boolean = { From 49d7e56b92f9d10d71204e2eccda9208bed78629 Mon Sep 17 00:00:00 2001 From: Kazuyuki Tanimura Date: Thu, 30 Jan 2025 14:38:35 -0800 Subject: [PATCH 2/2] fix: expressions doc for ArrayRemove --- docs/source/user-guide/expressions.md | 2 +- spark/src/main/scala/org/apache/comet/serde/arrays.scala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/source/user-guide/expressions.md b/docs/source/user-guide/expressions.md index 6125aa074..1cc6fa884 100644 --- a/docs/source/user-guide/expressions.md +++ b/docs/source/user-guide/expressions.md @@ -190,7 +190,7 @@ The following Spark expressions are currently available. Any known compatibility | ArrayContains | Experimental | | ArrayIntersect | Experimental | | ArrayJoin | Experimental | -| ArrayRemove | Experimental | +| ArrayRemove | | | ArraysOverlap | Experimental | | ElementAt | Arrays only | | GetArrayItem | | diff --git a/spark/src/main/scala/org/apache/comet/serde/arrays.scala b/spark/src/main/scala/org/apache/comet/serde/arrays.scala index 639e698ec..db1679f22 100644 --- a/spark/src/main/scala/org/apache/comet/serde/arrays.scala +++ b/spark/src/main/scala/org/apache/comet/serde/arrays.scala @@ -26,7 +26,7 @@ import org.apache.comet.CometSparkSessionExtensions.withInfo import org.apache.comet.serde.QueryPlanSerde.{createBinaryExpr, exprToProto} import org.apache.comet.shims.CometExprShim -object CometArrayRemove extends CometExpressionSerde with CometExprShim with IncompatExpr { +object CometArrayRemove extends CometExpressionSerde with CometExprShim { /** Exposed for unit testing */ def isTypeSupported(dt: DataType): Boolean = {