Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add support for Iceberg table identifiers with special characters #33292

Open
2 of 17 tasks
regadas opened this issue Dec 5, 2024 · 0 comments · May be fixed by #33293
Open
2 of 17 tasks

[Feature Request]: Add support for Iceberg table identifiers with special characters #33292

regadas opened this issue Dec 5, 2024 · 0 comments · May be fixed by #33293
Labels
awaiting triage IcebergIO IcebergIO: can only be used through ManagedIO io java new feature P2

Comments

@regadas
Copy link
Contributor

regadas commented Dec 5, 2024

What would you like to happen?

Currently, the IcebergIO internally uses TableIdentifier#parse and TableIdentifier#toString to encode/decode TableIdentifier. However, parse is using dot as a splitter not allowing cases where table names have dots i.e. default.table.id.

There are several approaches we can take here:

  1. support escaping using ", or ' or even i.edefault."table.id"`
  2. use Iceberg json representation https://github.com/apache/iceberg/blob/36140b819c60743b39176e28a63ab588df445329/core/src/main/java/org/apache/iceberg/catalog/TableIdentifierParser.java#L37-L40

I have a draft proposal using 2. #33293

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@liferoad liferoad added the IcebergIO IcebergIO: can only be used through ManagedIO label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage IcebergIO IcebergIO: can only be used through ManagedIO io java new feature P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants