Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Add tests to Kafka SDF and fix known and discovered issues #22303

Closed
johnjcasey opened this issue Jul 15, 2022 · 5 comments
Closed

[Task]: Add tests to Kafka SDF and fix known and discovered issues #22303

johnjcasey opened this issue Jul 15, 2022 · 5 comments

Comments

@johnjcasey
Copy link
Contributor

What needs to happen?

Kafka IO SDF currently has an issue where it is not restarting properly: #21730

In addition, there was a separate issue where it would not commit back to Kafka correctly.

As such, it appears that Kafka SDF has not been sufficiently tested, and the scope of this task is to test it more robustly, and fix both the linked issue, and any other issues discovered.

Issue Priority

Priority: 1

Issue Component

Component: io-java-kafka

@johnjcasey
Copy link
Contributor Author

@Abacn this issue can be used to track the kafka testing improvements

@johnjcasey
Copy link
Contributor Author

#22715 also

@pabloem
Copy link
Member

pabloem commented Oct 17, 2022

how should we triage this? should we assign it to @johnjcasey or @Abacn ?

@Abacn
Copy link
Contributor

Abacn commented Jan 8, 2023

Apparently Kafka performance test is failing again after #24879 in. This is because we removed shuffle=appliance there and then read from shuffle becomes faster. There are some reports that runner v2 is putting more pressure on kafka, and resulting in higher error rate. Now kafka server is overwhelmed with write requests and making write pipeline fail.

This reveals real issue of the code.

@johnjcasey
Copy link
Contributor Author

Closing as out of date. SDF Kafka has been significantly reworked, and is now in a much better state

@github-actions github-actions bot added this to the 2.62.0 Release milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants