-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBC driver for DataFusion #2263
Comments
fyi @alamb, curious what you think |
I think we would like projects to maintain their drivers (as DuckDB does), but the Rust target is also shifting. It's possible we should maintain it in -contrib or in tree until the Rust APIs have settled a bit before trying to upstream it so there is a reasonably stable target to follow. |
@mbrobbel maybe something to explore is versioning the Rust API definitions separately as well so there is a very stable target instead of churning the version number every 2 months for no reason |
I agree with this. Keeping it in tree helps to understand how changes to core traits impact existing drivers, and drivers must be updated as part of PRs that change these traits.
I agree it would be better to track this separately. There are a few things to consider:
|
Ah, I see (wrt arrow-rs types). In that case maybe there's not much value in separating the releases; we can just do minor version bumps. |
thanks, I'll open a PR here then. |
Only just now realized I was linking to a private repo in the description 🤦♂️ anyway.. PR is up at #2267 |
What feature or improvement would you like to see?
I started an adbc driver for datafusion in adbc-datafusion repo based on the rust dummy driver in this repo. It's mostly functional with support for
get_objects
, sql and substrait execution.I'm not sure what's the most appropriate home for the driver though. Should it go here in arrow-adbc repo, the main datafusion repository or maybe as an independent repository as a datafusion-contrib?
The text was updated successfully, but these errors were encountered: