Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csharp/src/Drivers/Apache: Rename this project and add NuGet creation #1726

Open
CurtHagenlocher opened this issue Apr 17, 2024 · 4 comments
Labels
Type: enhancement New feature or request

Comments

@CurtHagenlocher
Copy link
Contributor

What feature or improvement would you like to see?

The name "Apache.Arrow.Adbc.Drivers.Apache" isn't very meaningful. I'd propose "Apache.Arrow.Adbc.Drivers.HiveServer2" as an alternative but am open to other suggestions. The name should be finalized before we publish a NuGet package in order to avoid confusion.

@CurtHagenlocher CurtHagenlocher added the Type: enhancement New feature or request label Apr 17, 2024
@davidhcoe
Copy link
Contributor

I would actually prefer they each have their own names:

  • Apache.Arrow.Adbc.Drivers.Hive
  • Apache.Arrow.Adbc.Drivers.Impala
  • Apache.Arrow.Adbc.Drivers.Spark

but that would require splitting them to different projects and managing the dependencies accordingly.

@CurtHagenlocher
Copy link
Contributor Author

Splitting them is probably the right thing to do in a number of respects, but I wouldn't want to duplicate the code and for that we'd still need a single shared dependency.

@davidhcoe
Copy link
Contributor

I also thought about Apache.Arrow.Adbc.Drivers.Thrift since things all build on that, but that seemed less helpful

@birschick-bq
Copy link
Contributor

birschick-bq commented Apr 19, 2024

I think in the long term we don't want a shared artifact/nuget package for both drivers. It might limit the flexibility of release for each driver. So I'd vote for separate projects/artifacts for the two drivers. So a shared dependency on the Hive common code.

Once we get to working on Impala, we will probably discover more common code to share in the shared project.

Any, I agree with David's three names/projects:

  • Apache.Arrow.Adbc.Drivers.Hive (not really a driver, though)
  • Apache.Arrow.Adbc.Drivers.Impala
  • Apache.Arrow.Adbc.Drivers.Spark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants