Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: duplicated statistics names #1688

Closed
alexandreyc opened this issue Mar 29, 2024 · 1 comment · Fixed by #1736
Closed

format: duplicated statistics names #1688

alexandreyc opened this issue Mar 29, 2024 · 1 comment · Fixed by #1736
Labels
Type: question Usage question
Milestone
ADBC Libraries 12

Comments

@alexandreyc
Copy link
Contributor

What would you like help with?

Hello world!

While reading adbc.h I found that some statistics have the same name while having different keys.

For instance, both ADBC_STATISTIC_AVERAGE_BYTE_WIDTH_NAME and ADBC_STATISTIC_MAX_BYTE_WIDTH_NAME have the name adbc.statistic.byte_width.

Is this normal or it's a mistake?
@alexandreyc alexandreyc added the Type: question Usage question label Mar 29, 2024
@lidavidm lidavidm added this to the ADBC Libraries 1.0.0 milestone Apr 2, 2024
@lidavidm
Copy link
Member

A mistake. We can fix it.

@lidavidm lidavidm changed the title Duplicated statistics names format: duplicated statistics names Apr 19, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 19, 2024
@lidavidm
fix(format): correct duplicated statistics names
f8f7f97 
Fixes apache#1688.
@lidavidm lidavidm mentioned this issue Apr 19, 2024
Merged
lidavidm added a commit that referenced this issue Apr 22, 2024
@lidavidm
fix(format): correct duplicated statistics names (#1736)
75a4b64 
Fixes #1688.
cocoa-xu pushed a commit to cocoa-xu/arrow-adbc that referenced this issue Apr 24, 2024
@lidavidm @cocoa-xu
fix(format): correct duplicated statistics names (apache#1736)
a4ab18c 
Fixes apache#1688.
davidhcoe pushed a commit to davidhcoe/arrow-adbc that referenced this issue Apr 25, 2024
@lidavidm
fix(format): correct duplicated statistics names (apache#1736)
7b66e3f 
Fixes apache#1688.
cocoa-xu pushed a commit to meowcraft-dev/arrow-adbc that referenced this issue May 8, 2024
@lidavidm @cocoa-xu
fix(format): correct duplicated statistics names (apache#1736)
f8af64c 
Fixes apache#1688.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: question Usage question
Projects
None yet
Milestone
ADBC Libraries 12
Development

Successfully merging a pull request may close this issue.

fix(format): correct duplicated statistics names lidavidm/arrow-adbc
2 participants
@lidavidm @alexandreyc