Consolidate multiple Parsers/readers from same instrument manuf. #592
Labels
Status:Blocked
hard dependent or requires external inputs
Type:code_repo_consistency
code-repo wise quirks
Type:enhancement
General enhancements
Unit:Instrument Reader
Instrument parsers and related
Unit:Processing
preprocessing and transformations
Milestone
It would be nice if we can reduce the number of Parsers and readers in the Parsers directory, do some refactoring and reduce the range of parsers provided to the user.
Some parsers use weak logic, exists only given historical changes, don't use enough regexes to support reading important information, don't read the files with correct encoding, etc.
Examples:
We should aim to have a reader per Manufacturer with enough logic inside to handle multiple instruments and assigned names. This enables less guessing which reader to use, a single point of failure/success, less error in things such as names, comments, conversions, etc.
Also, some institutes created their parsers, and it can be hard to include then or merge changes without breakage.
However, only with a good set of tests, we can completely substitute the current infrastructure.
I will have to populate this issue with a list of related parsers, why they differ, etc. This way I can try to pinpoint the logic required for each manufacturer and if the generic parser needs updates.
For this issue to start, we've to collect more files for testing - I would say three variations for each equivalent instrument/parser.
The text was updated successfully, but these errors were encountered: