Made changes for svg #259
Made changes for svg #259
Conversation
Required
For the outlined version
Added Snapchat.svg
|
#237 just solved this issue |
|
@tangjinzhou @yesmeck @wendellhu95 @afc163 can you review these changes ? |
|
@Ishaan28malik great, used it on our project and it aligns with other circles perfectly, thank you! @tangjinzhou @yesmeck @wendellhu95 @afc163 any plans to merge it? |
|
@vagusX Please check this. |
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" standalone="no"?> | |||
There was a problem hiding this comment.
Why we need the file emtpy-circle and empty-square
There was a problem hiding this comment.
For the sake to create a checked one I added it.
|
Could you update your pr summary please? List all changes you made |
|
@vagusX sure let me re-write the changes. |
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" standalone="no"?> | |||
There was a problem hiding this comment.
For the sake to create a checked one I added it.
|
Snapchat seems OK. But other icon we may not accept since antd icons is produced by our designer. |
|
Please look into it as I have seen occasional need for an empty filled or outlined icons such as circle or square required to show status of various processes. |
|
Can we please merge this - no empty shapes is a glaring oversight |
Added Snapchat svg for Filled and Outlined versions .
Added empty circle , checked circle and square svg as mentioned in the issue 237