Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Leverage type hint and add checking #5194

Open
SMoraisAnsys opened this issue Sep 23, 2024 · 4 comments
Open

REFACTOR: Leverage type hint and add checking #5194

SMoraisAnsys opened this issue Sep 23, 2024 · 4 comments
Labels
good first issue Easy to solve for newcomers

Comments

@SMoraisAnsys
Copy link
Collaborator

We have deprecated IronPython so we should be able to use type hints ! This will help us to improve code clarity, catch potential bugs early, enhance IDE support (this one is particularly great), simplify maintenance, ...

For example

def retrieve_property(self, property_name: str) -> str :
    pass

Related to #5152

@SMoraisAnsys SMoraisAnsys added the good first issue Easy to solve for newcomers label Sep 23, 2024
@MaxJPRey
Copy link
Collaborator

It is for sure a huge work load, but definitely worth it, especially as you said for development in IDE by our users.

@vatsalrathod16
Copy link

I can work on this issue

@SMoraisAnsys
Copy link
Collaborator Author

I can work on this issue

Hey @vatsalrathod16, thanks for helping us, any contribution is welcome !
This is a HUGE task so I would advise to only work on a subset of the files. Feel free to pick whichever you like 👍

@vatsalrathod16
Copy link

Ok, I will try to complete it part by part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy to solve for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants