Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Poll] dropping support for older nexus versions ? #253

Closed
zeitounator opened this issue Feb 26, 2020 · 3 comments
Closed

[Poll] dropping support for older nexus versions ? #253

zeitounator opened this issue Feb 26, 2020 · 3 comments
Assignees

Comments

@zeitounator
Copy link
Member

zeitounator commented Feb 26, 2020

For this ticket your should read "Help wanted" as "I'll be happy to get a response in comments" :) This is actually an idea after a code review / discussion started in #252.

I am considering dropping support for older versions of nexus in the role. The goal here is to know the point to go down in version history. There are currently several issues:

  • Changes needed in groovy scripts to adapt to new version are not always backward compatible. Known issue: create_cleanup_policies_from_list will not function with nexus < 3.20 (although the role will work with older versions if you don't declare cleanup policies)
  • There are several admin password routines depending on version (before and after 3.17)
  • There is a path detection for restore dir (before and after version 3.11)
  • There is a path detection for the script API endpoint (before and after version 3.8)
  • There is a detection of list of application settings directories (before and after version 3.1)

Appart from the groovy scripts, where we do not always have a real solution (considering moving to rest API for those which is only available in recent versions as well), I'd like to clean-up the code from too old version detections.

What is in your opinion the oldest version this role should support (e.g. dropping support code for versions prior to) ? Please click on your choice. Thanks in advance to all users who will answer





@zeitounator zeitounator self-assigned this Feb 26, 2020
@zeitounator zeitounator pinned this issue Feb 26, 2020
@zeitounator zeitounator changed the title [Poll] dropping support of older nexus versions ? [Poll] dropping support for older nexus versions ? Feb 26, 2020
@wiget
Copy link
Contributor

wiget commented Feb 26, 2020

IMHO this role should support latest and one previous version of Nexus. This will be >= 3.20.0 currently.

@zeitounator
Copy link
Member Author

@wiget I since discovered gh-polls. If you are willing to give a click, help yourself.

@zeitounator
Copy link
Member Author

Thanks to all who participated. The trend is now clear for me. Il will from now on focus on latest nexus version and gradually clean up the code from old version checks when possible.

@zeitounator zeitounator unpinned this issue Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants