Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display MASP TX details in the confirmation popup #1442

Open
mateuszjasiuk opened this issue Dec 23, 2024 · 0 comments
Open

Display MASP TX details in the confirmation popup #1442

mateuszjasiuk opened this issue Dec 23, 2024 · 0 comments

Comments

@mateuszjasiuk
Copy link
Collaborator

mateuszjasiuk commented Dec 23, 2024

Details to display:

  • General Tx props (wrapper Tx, like all other Tx, fees, fee token, etc.)
  • Commitments
    • Sources
      • owner
      • token
      • amount
    • Targets
      • owner
      • token
      • amount
  • Shielded section hash (we should probably encode this as a string on Details, probably hex)

TODO What is left? We are currently displaying the above ^ for Shielding, confirming the other MASP tx...

List of Txs overview should indicate what type of shielded transfer (if it doesn't already, should be tested and confirmed to do the following):

  • Shielding (Transparent -> Shielded)
  • Shielded (Shielded -> Shielded)
  • Unshielding (Shielded -> Transparent)

NOTE It is already set up to do this, so this issue should primarily be about the Tx Data view, and what can be decoded from the submitted Tx to display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants