Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French affirmations #53

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ianlcz
Copy link

@ianlcz ianlcz commented Oct 25, 2024

Fixes #52

  • Implements of a query param lang which allows users to have English or French affirmations
  • Increase tests to have a best coverage
  • Improvement GitHub Actions workflow
  • Rework of the project architecture

- /assets/locales/: Affirmations in different langages
- /assets/: Importation affirmations file
- /utils/: Logical files
- Run GitHub Actions on every branches push
- Update actions/checkout and actions/step-node to v3
- Update Node version to 14
- Install rapidly dependencies with `npm ci`
- Set `lang` query param to allows user to have english (en) or french (fr) affirmations
- Implement test strategy
Copy link

welcome bot commented Oct 25, 2024

Thanks for opening this pull request! Please check out our contributing guidelines.

@ianlcz ianlcz changed the title French affirmations [#52]French affirmations Oct 25, 2024
@ianlcz ianlcz changed the title [#52]French affirmations French affirmations Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query to return French affirmations
1 participant