Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jira completion --help give the wrong instructions for naming fish completions file #788

Open
Drew-Daniels opened this issue Oct 17, 2024 · 0 comments

Comments

@Drew-Daniels
Copy link

Describe the bug
I referenced the output from jira completions --help to figure out how to generate the fish shell completions, and it recommended I do the following:

$ jira completion fish > ~/.config/fish/completions/_jira.fish

However, when I started a new fish shell, I wasn't getting any completions. It wasn't until I renamed _jira.fish to jira.fish that they started appearing, so I think the help doc needs to be updated since fish determines which completions to use based on the base file name, and since _jira didn't match jira, they weren't showing up.

Please provide following details

  1. JiraCLI Version:
(Version="1.5.2", GitCommit="34221786aaa12d5bc66039d164b6d9587b0799c7", CommitDate="2024-09-20T08:29:56+00:00", GoVersion="go1.23.1", Compiler="gc", Platform="darwin/arm64")
  1. Are you using Jira cloud or on-premise jira server?
SERVER INFO
-----------

Version:         1001.0.0-SNAPSHOT
Build Number:    100270
Deployment Type: Cloud
Default Locale:  en_US
  1. What operating system are you using? Also mention version.
macOS Sequoia 15.0.2 
  1. What terminal are you using? Also mention version.
iTerm2 Build 3.5.5

To Reproduce

Steps to reproduce the behavior:

  1. brew install jira fish
  2. jira init
  3. jira completion --help - see that it recommends the following step
  4. jira completion > ~/.config/fish/completions/_jira.fish
  5. Start a fish shell
  6. Type jira <TAB> and see that you do not get any completions
  7. Rename ~/.config/fish/completions/_jira.fish to ~/.config/fish/completions/jira.fish
  8. Exit fish shell
  9. Start another fish shell
  10. Type jira <TAB> and see that you now get completions

Expected behavior
I would expect the jira completion --help instructions specific to fish to suggest the correct filename to be used

Screenshots

Before rename (_jira.fish):

image

After rename to jira.fish:

image

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant