Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pontoon does not mark changed string as not-translated #3769

Open
sommerluk opened this issue Jan 25, 2025 · 2 comments
Open

Pontoon does not mark changed string as not-translated #3769

sommerluk opened this issue Jan 25, 2025 · 2 comments

Comments

@sommerluk
Copy link
Contributor

The pull request #3679 has changed the string deck-config-desired-retention-tooltip in ftl/core/deck-config.ftl. The original English string has also been updated accordingly in Pontoon. Here is the link for the German translation: https://i18n.ankiweb.net/de/core/core/templates/deck-config.ftl/?search=deck-config-desired-retention-tooltip&string=25342

Actual behaviour

The previous translation is still considered valid and up-to-date, despite the original English string being changed.

Expected behaviour

Either changing the existing string should mark the existing translation as “not translated“ or mark it somehow for review, so that translators get a chance to update it. Alternatively, deck-config-desired-retention-tooltip should not have been changed, and instead a new string, such as deck-config-desired-retention-tooltip2, should have been created, as done with other strings recently.

Note

I suspect this is a recurring problem because I've seen a couple of German translations of older strings saying something quite different from their English counterparts. Perhaps the same issue occurred there: the original string changed, and the translation was not updated.

@dae
Copy link
Member

dae commented Jan 25, 2025

I deliberately didn't add a new key, as that will break the existing translations, and it can take translators months or years to translate the new strings in some languages. My thinking was that for a non-English speaker, the old translated string, even though it mentions 0.9, is still going to be easier to understand than a correct string in a language the user doesn't understand.

@sommerluk
Copy link
Contributor Author

Fair point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants