Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release tool]: merge staging pull requests through the tool itself #313

Open
devversion opened this issue Nov 19, 2021 · 0 comments
Open

Comments

@devversion
Copy link
Member

Currently it is unclear what should be used to merge staging pull requests. We should just let the release tool merge the PR as it knows exactly where the PR should go into. The merge tool would rely on target labels which might not work temporarily e.g. when branching-off a feature freeze.

We should either merge automatically once the PR is approved + checks are passing, or we just add a double-prompt that can be submitted to manually start the merging (useful in case the PR checks are not significant as in COMP and FW - though worth noting that this could be done through a configuration as well in .ng-dev.)

The cherry-pick PRs should be merged automatically based on our discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant