- Short description and the purpose of this PR is present above this paragraph
- Your name is present in the AUTHORS file (optional)
If you have any questions or problems, please give a comment in the PR.
- PR name is meaningful
- Purpose of the PR is understood
- Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
- Commit descriptions are understandable and well formatted
- Source code changes are understandable
- Variable and function names are meaningful
- Code comments are correct (logically and spelling)
- Required documentation changes are present and part of the PR
-
bareos-check-sources --since-merge
does not report any problems -
git status
should not report modifications in the source tree after building and testing
- Decision taken that a system- or unittest is required (if not, then remove this paragraph)
- The decision towards a systemtest is reasonable compared to a unittest
- Testname matches exactly what is being tested
- Output of the test leads quickly to the origin of the fault