Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling and clean up client #431

Open
mmirman opened this issue Jan 4, 2024 · 5 comments
Open

Fix error handling and clean up client #431

mmirman opened this issue Jan 4, 2024 · 5 comments
Assignees
Labels
bug Something isn't working feat/enhancement New feature or request

Comments

@mmirman
Copy link
Contributor

mmirman commented Jan 4, 2024

https://github.com/anarchy-ai/LLM-VM/blob/main/src/llm_vm/client.py#L197C31-L197C31

This error handling is chaotic! We loose the stack trace frequently and there is unnecessary redirection. Please keep the stack trace so we can figure out what line things got broken on.

We use rebel even when tools is empty also!

@mmirman mmirman added bug Something isn't working feat/enhancement New feature or request labels Jan 4, 2024
@abhigya-sodani
Copy link
Contributor

Whats an example of using REBEL w/o tools

@mmirman
Copy link
Contributor Author

mmirman commented Jan 5, 2024

Thats the point. If you give it a tools object with no tools what happens?

@abhigya-sodani
Copy link
Contributor

Ok working on this. Pushed a fix that fixes Openai issues

@lucylililiwang
Copy link

lucylililiwang commented Feb 18, 2024

Hi, Can I please work on this issue? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants