Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If response is an error, $status might not be defined on ResponseParser.php #32

Open
raisen opened this issue Jul 5, 2016 · 4 comments

Comments

@raisen
Copy link

raisen commented Jul 5, 2016

If I receive an error response such as following:

<ErrorResponse xmlns="http://mws.amazonservices.com/schema/OffAmazonPayments/2013-01-01">
  <Error>
    <Type>Sender</Type>
    <Code>InvalidBillingAgreementId</Code>
    <Message>The BillingAgreementId C01-0006795-6194664 is invalid.</Message>
  </Error>
  <RequestId>63c96864-68ea-4d66-897a-08e8363c43f7</RequestId>
</ErrorResponse>

The getStatus() method on ResponseParser.php might not have $status defined as $path won't be found on the error response.

@mablae
Copy link

mablae commented Sep 19, 2016

@raisen Totally true. Is this lib even maintained? Anyone?

@bjguillot
Copy link
Contributor

@raisen, good catch.

@mablae, my team maintains the Login and Pay with Amazon SDKs. We take all issues entered and pull requests submitted very seriously. I can't publicly comment on any upcoming changes or timelines, but I can say that the team is busy working on the next version at this time.

@mablae
Copy link

mablae commented Sep 21, 2016

@bjguillot Nice to hear! Maybe I could provide some stuff as PR. This would be for a Release 3.x I think then? Is your team publishing its work to github before it hits master?

This would be nice to join efforts with Open Source community.

@jdfx
Copy link

jdfx commented Dec 28, 2020

Nearly 5 years later and this hasn't been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants