From be8d4137c03e032c4693bd21e5c71a99a3120a0c Mon Sep 17 00:00:00 2001 From: Erwin Mombay Date: Mon, 13 Jan 2025 14:51:20 -0800 Subject: [PATCH 1/2] unskip carousel e2e tests --- .../0.1/test-e2e/test-arrows-non-looping.js | 9 +++------ .../amp-base-carousel/0.1/test-e2e/test-carousel.js | 3 +-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js index 12ec711ea954..1e30efe0d6bc 100644 --- a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js +++ b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js @@ -31,21 +31,18 @@ describes.endtoend( nextArrow = await getNextArrow(controller); }); - // TODO(#40214): fix flaky test. - it.skip('should have the arrows in the correct initial state', async () => { + it('should have the arrows in the correct initial state', async () => { await expect(css(prevArrow, 'opacity')).to.equal('0'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); - // TODO(#40214): fix flaky test. - it.skip('should show the prev arrow when going to the first slide', async () => { + it('should show the prev arrow when going to the first slide', async () => { await controller.click(nextArrow); await expect(css(prevArrow, 'opacity')).to.equal('1'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); - // TODO(#40214): fix flaky test. - it.skip('should hide the next arrow when going to the end', async () => { + it('should hide the next arrow when going to the end', async () => { const el = await getScrollingElement(controller); await controller.scrollTo(el, {left: (SLIDE_COUNT - 1) * pageWidth}); diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js b/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js index c2060294d509..6a5136cbd72e 100644 --- a/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js +++ b/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js @@ -59,8 +59,7 @@ describes.endtoend( await expect(slidesRects[0].width).to.equal(pageWidth); }); - // TODO(#24195): fix this flaky test. - it.skip('should layout the two adjacent slides', async function () { + it('should layout the two adjacent slides', async function () { const [firstSlideRect, secondSlideRect, lastSlideRect] = [ await controller.getElementRect(await getSlide(controller, 0)), await controller.getElementRect(await getSlide(controller, 1)), From 754082a6e31b51dfae0a2fe73039cfdb0022a45d Mon Sep 17 00:00:00 2001 From: Erwin Mombay Date: Mon, 13 Jan 2025 15:48:37 -0800 Subject: [PATCH 2/2] remove failing tests on CI --- .../0.1/test-e2e/test-arrows-non-looping.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js index 1e30efe0d6bc..12ec711ea954 100644 --- a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js +++ b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js @@ -31,18 +31,21 @@ describes.endtoend( nextArrow = await getNextArrow(controller); }); - it('should have the arrows in the correct initial state', async () => { + // TODO(#40214): fix flaky test. + it.skip('should have the arrows in the correct initial state', async () => { await expect(css(prevArrow, 'opacity')).to.equal('0'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); - it('should show the prev arrow when going to the first slide', async () => { + // TODO(#40214): fix flaky test. + it.skip('should show the prev arrow when going to the first slide', async () => { await controller.click(nextArrow); await expect(css(prevArrow, 'opacity')).to.equal('1'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); - it('should hide the next arrow when going to the end', async () => { + // TODO(#40214): fix flaky test. + it.skip('should hide the next arrow when going to the end', async () => { const el = await getScrollingElement(controller); await controller.scrollTo(el, {left: (SLIDE_COUNT - 1) * pageWidth});