Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Unused Secrets #6

Open
wangeguo opened this issue May 4, 2023 · 0 comments
Open

Clean up Unused Secrets #6

wangeguo opened this issue May 4, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@wangeguo
Copy link
Member

wangeguo commented May 4, 2023

When amp-configurations is modified, Configuration Watcher listens for changes and usually updates the corresponding Secret and Service Account. There are three possible scenarios:

  1. If there are no new modifications, there are no substantial changes (Kubernetes will not perform any update operations if no changes are detected).
    2 If any new registry or repository is added during the modification, Configuration Watcher synchronizes the creation of corresponding registry secrets or repo secrets.
  2. If any registry or repository is no longer used, its corresponding Secret must be deleted. Unfortunately, this scenario is not yet supported.

To fix this issue, we propose comparing the current amp-configurations with the new amp-configuration and creating Secrets for new items while deleting the Secrets for any missing items.

See: https://github.com/amphitheatre-app/amphitheatre/blob/master/resources/src/credential.rs#L39

@wangeguo wangeguo added the bug Something isn't working label May 4, 2023
@wangeguo wangeguo self-assigned this May 4, 2023
@wangeguo wangeguo moved this to Todo in Amphitheatre May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Todo
Development

No branches or pull requests

1 participant