Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing imports #115

Closed
Timm638 opened this issue Jan 7, 2025 · 0 comments · Fixed by #116
Closed

Fixing missing imports #115

Timm638 opened this issue Jan 7, 2025 · 0 comments · Fixed by #116
Assignees
Labels
bug Something isn't working draft Draft to be reviwed by a PO

Comments

@Timm638
Copy link

Timm638 commented Jan 7, 2025

Describe the bug
The init.py files have been cleared after the restructuring of the pipeline components done in #90 . While this makes working with the library not impossible, it bloats the code needed for importing components, especially for #96 .

To Reproduce

Steps to reproduce the behavior:

  1. Pull RTDIP Demo Notebook #49
  2. Merge commit 0277a5c into the branch, accept files from branch
  3. See that even when correctly renaming the imports they aren't working anymore

Expected behavior

Imports in the notebook is working

Screenshot

image

@Timm638 Timm638 added bug Something isn't working draft Draft to be reviwed by a PO labels Jan 7, 2025
@Timm638 Timm638 self-assigned this Jan 7, 2025
@Timm638 Timm638 moved this from Sprint Backlog to Product Backlog in amos2024ws01-feature-board Jan 7, 2025
@Timm638 Timm638 changed the title Fixing messed up imports Fixing missing imports Jan 7, 2025
@Timm638 Timm638 linked a pull request Jan 7, 2025 that will close this issue
@Timm638 Timm638 moved this from Product Backlog to Awaiting Review in amos2024ws01-feature-board Jan 7, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Review to Feature Archive in amos2024ws01-feature-board Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working draft Draft to be reviwed by a PO
Projects
Status: Feature Archive
Development

Successfully merging a pull request may close this issue.

1 participant