Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of the build files #204

Open
Freeze-FF opened this issue Jan 14, 2024 · 4 comments
Open

Improvements of the build files #204

Freeze-FF opened this issue Jan 14, 2024 · 4 comments

Comments

@Freeze-FF
Copy link
Contributor

Freeze-FF commented Jan 14, 2024

User story

  1. As a user
  2. I want / need an windows .exe file and an .msi installer
  3. So that I can direclty run that application using Windows

Acceptance criteria

  • For every new release, there should be an .exe file and an .msi installer.
  • The .exe file should run without (security) warnings or any other issues
  • Is it possible to exclude certain dependencies so that the build file becomes smaller?
  • The distributables should not become so large!
  • Code and libraries are actually rather small, if necessary, throw something out if not needed.

Definition of done (DoD)

  • Create feature branch
  • Implement the functionality
  • Opened pull request and assigned reviewer
  • If necessary: required changes are implemented
  • Delete feature branch
  • If necessary: Component Test has been written
  • Code review has been completed and code has been merged

DoD general criteria

  • Feature has been fully implemented
  • Feature has been merged into the mainline
  • All acceptance criteria were met
  • Product owner approved features
  • All tests are passing
  • Developers agreed to release
@Freeze-FF Freeze-FF moved this to Product Backlog in amos2023ws03-feature-board Jan 14, 2024
@Freeze-FF Freeze-FF moved this from Product Backlog to Sprint Backlog in amos2023ws03-feature-board Jan 17, 2024
@Freeze-FF Freeze-FF moved this from Sprint Backlog to Product Backlog in amos2023ws03-feature-board Jan 17, 2024
@Freeze-FF Freeze-FF moved this from Product Backlog to Sprint Backlog in amos2023ws03-feature-board Jan 31, 2024
@zino212
Copy link
Contributor

zino212 commented Feb 2, 2024

Both .exe and .msi are currently individually 0.98 GB on my machine.

@simonsasse
Copy link
Contributor

so if I delete all iOS, windows, linux files in the GUI/contents/app folder within the package executable. I can reduce size from 1.18GB to 348GB

@zino212 zino212 moved this from Sprint Backlog to In Progress in amos2023ws03-feature-board Feb 5, 2024
@simonsasse
Copy link
Contributor

I suggest we write a script that goes through the subfolder of the executable where all these .jars are and deletes everything containing macOS, android, iOS, linux (If on windows) etc. und wenn es mal was kaputt mach muessen wir schauen. Aber so hab ich mein build Auf 340mb bekommen.
Man koennte das sogar automatisieren in GH actions

@simonsasse
Copy link
Contributor

or we add it to the Gradle task createDistributable.

@fs3itz fs3itz moved this from In Progress to Awaiting Review in amos2023ws03-feature-board Feb 6, 2024
@Freeze-FF Freeze-FF moved this from Awaiting Review to Feature Archive in amos2023ws03-feature-board Feb 6, 2024
@Freeze-FF Freeze-FF moved this from Feature Archive to Awaiting Review in amos2023ws03-feature-board Feb 6, 2024
@lukas-monet lukas-monet moved this from Awaiting Review to Feature Archive in amos2023ws03-feature-board Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Feature Archive
Development

No branches or pull requests

5 participants