diff --git a/frontend/src/app/api.service.ts b/frontend/src/app/api.service.ts index 7562230..6f882d2 100644 --- a/frontend/src/app/api.service.ts +++ b/frontend/src/app/api.service.ts @@ -19,7 +19,7 @@ export class ApiService { constructor(private http: HttpClient) {} - // Handle Errors -- TODO use it + // Handle Errors -- TODO use it to have better and consistent error messages. (but do we need them?) error(error: HttpErrorResponse): Observable { let errorMessage: string = ''; if (error.error instanceof ErrorEvent) { diff --git a/frontend/src/app/repository-details/repository-details.component.ts b/frontend/src/app/repository-details/repository-details.component.ts index 57a3943..86cb15d 100644 --- a/frontend/src/app/repository-details/repository-details.component.ts +++ b/frontend/src/app/repository-details/repository-details.component.ts @@ -24,7 +24,7 @@ export class RepositoryDetailsComponent implements OnInit { }; getdata = false; doughnutChart; - + lastLintTime; latestLintingIndex: number; latestLintingResults: CheckResults[]; diff --git a/server/src/main/java/amosproj/server/linter/Linter.java b/server/src/main/java/amosproj/server/linter/Linter.java index 420389d..15c9678 100644 --- a/server/src/main/java/amosproj/server/linter/Linter.java +++ b/server/src/main/java/amosproj/server/linter/Linter.java @@ -70,7 +70,7 @@ public void checkEverything(org.gitlab4j.api.models.Project apiProject, LocalDat LintingResult lintingResult = new LintingResult(currLintingProject, timestamp); lintingResultRepository.save(lintingResult); - // TODO multithreaded in ThreadPool oder ExecutorService + // TODO performance: multithreaded in ThreadPool oder ExecutorService runChecks(apiProject, lintingResult); } diff --git a/server/src/main/java/amosproj/server/linter/checks/Check.java b/server/src/main/java/amosproj/server/linter/checks/Check.java index 676d507..fb1a760 100644 --- a/server/src/main/java/amosproj/server/linter/checks/Check.java +++ b/server/src/main/java/amosproj/server/linter/checks/Check.java @@ -34,7 +34,7 @@ public static void run(String checkName, GitLab gitLab, Project project, CheckRe Method method = obj.getDeclaredMethod("evaluate", GitLab.class, Project.class); result = (boolean) method.invoke(obj.getConstructor().newInstance(), gitLab, project); } catch (ClassNotFoundException | NoSuchMethodException | InvocationTargetException | IllegalAccessException | InstantiationException e) { - // TODO handle some of the exceptions differently (e.g. return false upon ClassNotFound Exception. + // TODO handle some of the exceptions differently (e.g. return false upon ClassNotFound Exception). e.printStackTrace(); } CheckResult cr = new CheckResult(lintingResult, checkName, result);